Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-18 Thread Arnd Bergmann
On Mon, Jun 18, 2018 at 11:39 AM, Wu, Songjun wrote: > > > On 6/14/2018 6:07 PM, Arnd Bergmann wrote: >> >> On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu >> wrote: >>> >>> Previous implementation uses platform-dependent functions >>> ltq_w32()/ltq_r32() to access registers. Those functions are not

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-18 Thread Arnd Bergmann
On Mon, Jun 18, 2018 at 11:39 AM, Wu, Songjun wrote: > > > On 6/14/2018 6:07 PM, Arnd Bergmann wrote: >> >> On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu >> wrote: >>> >>> Previous implementation uses platform-dependent functions >>> ltq_w32()/ltq_r32() to access registers. Those functions are not

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-18 Thread Wu, Songjun
On 6/14/2018 6:07 PM, Arnd Bergmann wrote: On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu wrote: Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-18 Thread Wu, Songjun
On 6/14/2018 6:07 PM, Arnd Bergmann wrote: On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu wrote: Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-14 Thread Arnd Bergmann
On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu wrote: > Previous implementation uses platform-dependent functions > ltq_w32()/ltq_r32() to access registers. Those functions are not > available for other SoC which uses the same IP. > Change to OS provided readl()/writel() and readb()/writeb(), so >

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-14 Thread Arnd Bergmann
On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu wrote: > Previous implementation uses platform-dependent functions > ltq_w32()/ltq_r32() to access registers. Those functions are not > available for other SoC which uses the same IP. > Change to OS provided readl()/writel() and readb()/writeb(), so >

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-14 Thread Wu, Songjun
On 6/12/2018 4:13 PM, Andy Shevchenko wrote: On Tue, Jun 12, 2018 at 8:40 AM, Songjun Wu wrote: Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-14 Thread Wu, Songjun
On 6/12/2018 4:13 PM, Andy Shevchenko wrote: On Tue, Jun 12, 2018 at 8:40 AM, Songjun Wu wrote: Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-12 Thread Andy Shevchenko
On Tue, Jun 12, 2018 at 8:40 AM, Songjun Wu wrote: > Previous implementation uses platform-dependent functions > ltq_w32()/ltq_r32() to access registers. Those functions are not > available for other SoC which uses the same IP. > Change to OS provided readl()/writel() and readb()/writeb(), so >

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-12 Thread Andy Shevchenko
On Tue, Jun 12, 2018 at 8:40 AM, Songjun Wu wrote: > Previous implementation uses platform-dependent functions > ltq_w32()/ltq_r32() to access registers. Those functions are not > available for other SoC which uses the same IP. > Change to OS provided readl()/writel() and readb()/writeb(), so >

[PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-11 Thread Songjun Wu
Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided readl()/writel() and readb()/writeb(), so that different SoCs can use the same driver. Signed-off-by:

[PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-11 Thread Songjun Wu
Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided readl()/writel() and readb()/writeb(), so that different SoCs can use the same driver. Signed-off-by: