Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-08 Thread Marcin Slusarz
On Tue, Jan 08, 2008 at 11:17:32AM +0100, Jan Kara wrote: > On Mon 07-01-08 22:10:01, Marcin Slusarz wrote: > > On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote: > > > On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote: > > > > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> > > > I'm

Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-08 Thread Jan Kara
On Mon 07-01-08 22:10:01, Marcin Slusarz wrote: > On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote: > > On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote: > > > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> > > I'm not sure if this improves readability in general. If the code is > >

Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-08 Thread Jan Kara
On Mon 07-01-08 22:10:01, Marcin Slusarz wrote: On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote: On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] I'm not sure if this improves readability in general. If the code is really a

Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-08 Thread Marcin Slusarz
On Tue, Jan 08, 2008 at 11:17:32AM +0100, Jan Kara wrote: On Mon 07-01-08 22:10:01, Marcin Slusarz wrote: On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote: On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] I'm not sure if this

Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-07 Thread Marcin Slusarz
On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote: > On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote: > > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> > I'm not sure if this improves readability in general. If the code is > really a loop in nature, then we should code it using do

Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-07 Thread Jan Kara
On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote: > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> I'm not sure if this improves readability in general. If the code is really a loop in nature, then we should code it using do {} while but in case we loop back just in case of some error (as

Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-07 Thread Jan Kara
On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] I'm not sure if this improves readability in general. If the code is really a loop in nature, then we should code it using do {} while but in case we loop back just in case of some error (as seems

Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-07 Thread Marcin Slusarz
On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote: On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] I'm not sure if this improves readability in general. If the code is really a loop in nature, then we should code it using do {} while

[PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-05 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> --- fs/udf/balloc.c | 309 --- 1 files changed, 157 insertions(+), 152 deletions(-) diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c index d1d4b8f..5ce7926 100644 --- a/fs/udf/balloc.c +++

[PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-05 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] --- fs/udf/balloc.c | 309 --- 1 files changed, 157 insertions(+), 152 deletions(-) diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c index d1d4b8f..5ce7926 100644 --- a/fs/udf/balloc.c +++