Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it

2016-05-30 Thread Borislav Petkov
On Sun, May 29, 2016 at 12:08:29PM -0700, Andy Lutomirski wrote: > Sure, but how do I implement that? There's no "does this arch have > addr_limit in thread_info" general flag that I know of. What about get_fs()? Looks like all arches implement that and on sparc it is something called thread_info

Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it

2016-05-29 Thread Andy Lutomirski
On May 29, 2016 11:42 AM, "Boris Petkov" wrote: > > Andy Lutomirski wrote: > >Easier said than done. struct thread_info doesn't have addr_limit on > >sensible architectures (e.g. sparc), and I'd rather not stick a bunch > >of ifdefs in generic code. > > It's not like it doesn't have an actual ad

Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it

2016-05-29 Thread Boris Petkov
Andy Lutomirski wrote: >Easier said than done. struct thread_info doesn't have addr_limit on >sensible architectures (e.g. sparc), and I'd rather not stick a bunch >of ifdefs in generic code. It's not like it doesn't have an actual address limit though - I'm guessing it is something like the ma

Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it

2016-05-29 Thread Andy Lutomirski
On Wed, May 25, 2016 at 4:39 AM, Borislav Petkov wrote: > On Tue, May 24, 2016 at 03:48:41PM -0700, Andy Lutomirski wrote: >> This will help debug OOPSes related to USER_DS vs KERNEL_DS. >> >> Signed-off-by: Andy Lutomirski >> --- >> arch/x86/kernel/dumpstack_32.c | 4 >> arch/x86/kernel/du

Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it

2016-05-29 Thread Andy Lutomirski
On Wed, May 25, 2016 at 4:32 AM, Borislav Petkov wrote: > On Tue, May 24, 2016 at 03:48:41PM -0700, Andy Lutomirski wrote: >> This will help debug OOPSes related to USER_DS vs KERNEL_DS. >> >> Signed-off-by: Andy Lutomirski >> --- >> arch/x86/kernel/dumpstack_32.c | 4 >> arch/x86/kernel/du

Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it

2016-05-25 Thread Borislav Petkov
On Tue, May 24, 2016 at 03:48:41PM -0700, Andy Lutomirski wrote: > This will help debug OOPSes related to USER_DS vs KERNEL_DS. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/kernel/dumpstack_32.c | 4 > arch/x86/kernel/dumpstack_64.c | 5 + > 2 files changed, 9 insertions(+) > >

Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it

2016-05-25 Thread Borislav Petkov
On Tue, May 24, 2016 at 03:48:41PM -0700, Andy Lutomirski wrote: > This will help debug OOPSes related to USER_DS vs KERNEL_DS. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/kernel/dumpstack_32.c | 4 > arch/x86/kernel/dumpstack_64.c | 5 + > 2 files changed, 9 insertions(+) > >

[PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it

2016-05-24 Thread Andy Lutomirski
This will help debug OOPSes related to USER_DS vs KERNEL_DS. Signed-off-by: Andy Lutomirski --- arch/x86/kernel/dumpstack_32.c | 4 arch/x86/kernel/dumpstack_64.c | 5 + 2 files changed, 9 insertions(+) diff --git a/arch/x86/kernel/dumpstack_32.c b/arch/x86/kernel/dumpstack_32.c index