Re: [PATCH 4/8] extcon: gpio: Convert to fully use GPIO descriptor

2017-09-25 Thread Chanwoo Choi
Hi Linus, Looks good to me. But, there is one comment of gpiod_to_irq()'s return value. If you modify it, feel free to add my tag: Acked-by: Chanwoo Choi On 2017년 09월 24일 23:56, Linus Walleij wrote: > Since we are not getting the GPIO from any platform data and global > GPIO numberspace, we sim

[PATCH 4/8] extcon: gpio: Convert to fully use GPIO descriptor

2017-09-24 Thread Linus Walleij
Since we are not getting the GPIO from any platform data and global GPIO numberspace, we simply get the named "extcon" GPIO directly from the device. Cut away "active low" since GPIO descriptors already know if the line is active high or low. Simplify a bit with a struct device *dev helper variable