Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-20 Thread Thomas Niederprüm
Am Fri, 20 Mar 2015 17:25:29 +0200 schrieb Tomi Valkeinen : > On 20/03/15 16:47, Maxime Ripard wrote: > > On Fri, Mar 20, 2015 at 01:37:50PM +0200, Tomi Valkeinen wrote: > >> On 15/03/15 00:02, Geert Uytterhoeven wrote: > >>> On Fri, Mar 13, 2015 at 10:31 PM, Thomas Niederprüm > >>> wrote: >

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-20 Thread Thomas Niederprüm
Am Fri, 20 Mar 2015 16:24:29 +0100 schrieb Geert Uytterhoeven : > On Fri, Mar 20, 2015 at 3:47 PM, Maxime Ripard > wrote: > > On Fri, Mar 20, 2015 at 01:37:50PM +0200, Tomi Valkeinen wrote: > >> On 15/03/15 00:02, Geert Uytterhoeven wrote: > >> > On Fri, Mar 13, 2015 at 10:31 PM, Thomas Niederprü

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-20 Thread Tomi Valkeinen
On 20/03/15 16:47, Maxime Ripard wrote: > On Fri, Mar 20, 2015 at 01:37:50PM +0200, Tomi Valkeinen wrote: >> On 15/03/15 00:02, Geert Uytterhoeven wrote: >>> On Fri, Mar 13, 2015 at 10:31 PM, Thomas Niederprüm >>> wrote: Am Tue, 10 Mar 2015 13:28:25 +0200 schrieb Tomi Valkeinen : > A

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-20 Thread Geert Uytterhoeven
On Fri, Mar 20, 2015 at 3:47 PM, Maxime Ripard wrote: > On Fri, Mar 20, 2015 at 01:37:50PM +0200, Tomi Valkeinen wrote: >> On 15/03/15 00:02, Geert Uytterhoeven wrote: >> > On Fri, Mar 13, 2015 at 10:31 PM, Thomas Niederprüm >> > wrote: >> >> Am Tue, 10 Mar 2015 13:28:25 +0200 >> >> schrieb Tomi

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-20 Thread Maxime Ripard
On Fri, Mar 20, 2015 at 01:37:50PM +0200, Tomi Valkeinen wrote: > On 15/03/15 00:02, Geert Uytterhoeven wrote: > > On Fri, Mar 13, 2015 at 10:31 PM, Thomas Niederprüm > > wrote: > >> Am Tue, 10 Mar 2015 13:28:25 +0200 > >> schrieb Tomi Valkeinen : > >>> Also, isn't doing __pa() for the memory retu

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-20 Thread Geert Uytterhoeven
On Fri, Mar 20, 2015 at 12:37 PM, Tomi Valkeinen wrote: > On 15/03/15 00:02, Geert Uytterhoeven wrote: >> On Fri, Mar 13, 2015 at 10:31 PM, Thomas Niederprüm >> wrote: >>> Am Tue, 10 Mar 2015 13:28:25 +0200 >>> schrieb Tomi Valkeinen : Also, isn't doing __pa() for the memory returned by vmal

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-20 Thread Tomi Valkeinen
On 15/03/15 00:02, Geert Uytterhoeven wrote: > On Fri, Mar 13, 2015 at 10:31 PM, Thomas Niederprüm > wrote: >> Am Tue, 10 Mar 2015 13:28:25 +0200 >> schrieb Tomi Valkeinen : >>> Also, isn't doing __pa() for the memory returned by vmalloc plain >>> wrong? >> >>> What was the crash about when using

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-14 Thread Geert Uytterhoeven
On Fri, Mar 13, 2015 at 10:31 PM, Thomas Niederprüm wrote: > Am Tue, 10 Mar 2015 13:28:25 +0200 > schrieb Tomi Valkeinen : >> Also, isn't doing __pa() for the memory returned by vmalloc plain >> wrong? > >> What was the crash about when using kmalloc? It would be good to fix >> defio, as I don't s

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-13 Thread Thomas Niederprüm
Am Tue, 10 Mar 2015 13:28:25 +0200 schrieb Tomi Valkeinen : > On 14/02/15 16:22, Thomas Niederprüm wrote: > > Am Thu, 12 Feb 2015 16:11:21 +0100 > > schrieb Maxime Ripard : > > > >> On Sat, Feb 07, 2015 at 04:35:41PM +0100, Thomas Niederprüm wrote: > >>> Am Sat, 7 Feb 2015 12:18:21 +0100 > >>> sc

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-03-10 Thread Tomi Valkeinen
On 14/02/15 16:22, Thomas Niederprüm wrote: > Am Thu, 12 Feb 2015 16:11:21 +0100 > schrieb Maxime Ripard : > >> On Sat, Feb 07, 2015 at 04:35:41PM +0100, Thomas Niederprüm wrote: >>> Am Sat, 7 Feb 2015 12:18:21 +0100 >>> schrieb Maxime Ripard : >>> Hi, On Fri, Feb 06, 2015 at 11:28:

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-02-14 Thread Maxime Ripard
On Sat, Feb 14, 2015 at 03:22:12PM +0100, Thomas Niederprüm wrote: > Am Thu, 12 Feb 2015 16:11:21 +0100 > schrieb Maxime Ripard : > > > On Sat, Feb 07, 2015 at 04:35:41PM +0100, Thomas Niederprüm wrote: > > > Am Sat, 7 Feb 2015 12:18:21 +0100 > > > schrieb Maxime Ripard : > > > > > > > Hi, > > >

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-02-14 Thread Thomas Niederprüm
Am Thu, 12 Feb 2015 16:11:21 +0100 schrieb Maxime Ripard : > On Sat, Feb 07, 2015 at 04:35:41PM +0100, Thomas Niederprüm wrote: > > Am Sat, 7 Feb 2015 12:18:21 +0100 > > schrieb Maxime Ripard : > > > > > Hi, > > > > > > On Fri, Feb 06, 2015 at 11:28:10PM +0100, nied...@physik.uni-kl.de > > > wro

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-02-12 Thread Maxime Ripard
On Sat, Feb 07, 2015 at 04:35:41PM +0100, Thomas Niederprüm wrote: > Am Sat, 7 Feb 2015 12:18:21 +0100 > schrieb Maxime Ripard : > > > Hi, > > > > On Fri, Feb 06, 2015 at 11:28:10PM +0100, nied...@physik.uni-kl.de > > wrote: > > > From: Thomas Niederprüm > > > > > > It makes sense to use vmallo

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-02-07 Thread Thomas Niederprüm
Am Sat, 7 Feb 2015 12:18:21 +0100 schrieb Maxime Ripard : > Hi, > > On Fri, Feb 06, 2015 at 11:28:10PM +0100, nied...@physik.uni-kl.de > wrote: > > From: Thomas Niederprüm > > > > It makes sense to use vmalloc to allocate the video buffer since it > > has to be page aligned memory for using it

Re: [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-02-07 Thread Maxime Ripard
Hi, On Fri, Feb 06, 2015 at 11:28:10PM +0100, nied...@physik.uni-kl.de wrote: > From: Thomas Niederprüm > > It makes sense to use vmalloc to allocate the video buffer since it > has to be page aligned memory for using it with mmap. Please wrap your commit log at 80 chars. It looks like there's

[PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory.

2015-02-06 Thread niederp
From: Thomas Niederprüm It makes sense to use vmalloc to allocate the video buffer since it has to be page aligned memory for using it with mmap. Also deffered io seems buggy in combination with kmalloc'ed memory (crash on unloading the module). Signed-off-by: Thomas Niederprüm --- drivers/v