Re: [PATCH 4/8] iio: Add support for DA9150 GPADC

2014-06-21 Thread Jonathan Cameron
On 16/06/14 16:58, Opensource [Adam Thomson] wrote: On June 15, 2014 21:19, Jonathon Cameron wrote: Hi Adam Reasonably clean code, but the _ channels stuff doesn't comply with the ABI and is rather confusing. To be honest I did debate this in my head for a while. The reason I went with the c

RE: [PATCH 4/8] iio: Add support for DA9150 GPADC

2014-06-16 Thread Opensource [Adam Thomson]
On June 15, 2014 21:19, Jonathon Cameron wrote: > Hi Adam > > Reasonably clean code, but the _ channels stuff doesn't comply with the ABI > and is rather confusing. To be honest I did debate this in my head for a while. The reason I went with the current approach was to make the driver channel l

Re: [PATCH 4/8] iio: Add support for DA9150 GPADC

2014-06-15 Thread Jonathan Cameron
On 11/06/14 12:11, Adam Thomson wrote: This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. Signed-off-by: Adam Thomson Hi Adam Reasonably clean code, but the _ channels stuff doesn't comply with the ABI and is rather confusing. If it really does make sense to allow reading thes

Re: [PATCH 4/8] iio: Add support for DA9150 GPADC

2014-06-15 Thread Jonathan Cameron
On 11/06/14 17:56, Opensource [Adam Thomson] wrote: On June 11, 2014 17:35, Jonathon Cameron wrote: Hi Adam. Silly question but what are the _ channels? I have put in a perhaps optimistic data sheet request via the website, throwing in your name. Hope you don't mind! Jonathan Hi Jonathon.

RE: [PATCH 4/8] iio: Add support for DA9150 GPADC

2014-06-11 Thread Opensource [Adam Thomson]
On June 11, 2014 17:35, Jonathon Cameron wrote: > Hi Adam. Silly question but what are the _ channels? > > I have put in a perhaps optimistic data sheet request via the website, > throwing in > your name. Hope you don't mind! > > Jonathan Hi Jonathon. Some of the _channels are a different repr

Re: [PATCH 4/8] iio: Add support for DA9150 GPADC

2014-06-11 Thread Jonathan Cameron
On June 11, 2014 12:11:28 PM GMT+01:00, Adam Thomson wrote: >This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > >Signed-off-by: Adam Thomson Hi Adam. Silly question but what are the _ channels? I have put in a perhaps optimistic data sheet request via the website, throwing i

[PATCH 4/8] iio: Add support for DA9150 GPADC

2014-06-11 Thread Adam Thomson
This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. Signed-off-by: Adam Thomson --- drivers/iio/adc/Kconfig | 9 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/da9150-gpadc.c | 396 +++ include/linux/mfd/da9150/gpadc.h |