Re: [PATCH 4/8] mm: vmscan: naming fixes: global_reclaim() and sane_reclaim()

2019-10-23 Thread Johannes Weiner
On Tue, Oct 22, 2019 at 07:40:52PM +, Roman Gushchin wrote: > On Tue, Oct 22, 2019 at 10:47:59AM -0400, Johannes Weiner wrote: > > Seven years after introducing the global_reclaim() function, I still > > have to double take when reading a callsite. I don't know how others > > do it, this is a

Re: [PATCH 4/8] mm: vmscan: naming fixes: global_reclaim() and sane_reclaim()

2019-10-23 Thread Johannes Weiner
On Wed, Oct 23, 2019 at 04:14:36PM +0200, Michal Hocko wrote: > On Tue 22-10-19 10:47:59, Johannes Weiner wrote: > > Seven years after introducing the global_reclaim() function, I still > > have to double take when reading a callsite. I don't know how others > > do it, this is a terrible name. >

Re: [PATCH 4/8] mm: vmscan: naming fixes: global_reclaim() and sane_reclaim()

2019-10-23 Thread Michal Hocko
On Tue 22-10-19 10:47:59, Johannes Weiner wrote: > Seven years after introducing the global_reclaim() function, I still > have to double take when reading a callsite. I don't know how others > do it, this is a terrible name. I somehow never had problem with that but ... > > Invert the meaning

Re: [PATCH 4/8] mm: vmscan: naming fixes: global_reclaim() and sane_reclaim()

2019-10-22 Thread Roman Gushchin
On Tue, Oct 22, 2019 at 10:47:59AM -0400, Johannes Weiner wrote: > Seven years after introducing the global_reclaim() function, I still > have to double take when reading a callsite. I don't know how others > do it, this is a terrible name. > > Invert the meaning and rename it to

[PATCH 4/8] mm: vmscan: naming fixes: global_reclaim() and sane_reclaim()

2019-10-22 Thread Johannes Weiner
Seven years after introducing the global_reclaim() function, I still have to double take when reading a callsite. I don't know how others do it, this is a terrible name. Invert the meaning and rename it to cgroup_reclaim(). [ After all, "global reclaim" is just regular reclaim invoked from the