Re: [PATCH 4/8] regulator: arizona-ldo1: Add processing of init_data from device tree

2014-03-18 Thread Mark Brown
On Tue, Mar 18, 2014 at 04:07:01PM +, Charles Keepax wrote: > On Tue, Mar 18, 2014 at 11:15:42AM +, Mark Brown wrote: > > On Tue, Mar 18, 2014 at 10:49:13AM +, Charles Keepax wrote: > > > + np_init = of_get_child_by_name(arizona->dev->of_node, "wlf,ldo1"); > > You're missing an of_nod

Re: [PATCH 4/8] regulator: arizona-ldo1: Add processing of init_data from device tree

2014-03-18 Thread Charles Keepax
On Tue, Mar 18, 2014 at 11:15:42AM +, Mark Brown wrote: > On Tue, Mar 18, 2014 at 10:49:13AM +, Charles Keepax wrote: > > > + - wlf,ldo1 : Initial data for the LDO1 regulator, as covered in > > +Documentation/devicetree/bindings/regulator/regulator.txt > > We don't normally prefix th

Re: [PATCH 4/8] regulator: arizona-ldo1: Add processing of init_data from device tree

2014-03-18 Thread Mark Brown
On Tue, Mar 18, 2014 at 10:49:13AM +, Charles Keepax wrote: > + - wlf,ldo1 : Initial data for the LDO1 regulator, as covered in > +Documentation/devicetree/bindings/regulator/regulator.txt We don't normally prefix the names of the regulator data with a vendor. > + np_init = of_get_c

[PATCH 4/8] regulator: arizona-ldo1: Add processing of init_data from device tree

2014-03-18 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Documentation/devicetree/bindings/mfd/arizona.txt |7 + drivers/regulator/arizona-ldo1.c | 26 + 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Do