Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-11 Thread Andy Shevchenko
On Fri, Dec 11, 2015 at 11:29 AM, Vinod Koul wrote: > On Thu, Dec 10, 2015 at 06:38:09AM +, Wang, Annie wrote: >> > >> >Why not DT or ACPI for this? >> > >> We choose to use private data, as pl330 already has struct >> dma_pl330_platdata. >> Physically DMA share ACPI device with UART,

Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-11 Thread Vinod Koul
On Thu, Dec 10, 2015 at 06:38:09AM +, Wang, Annie wrote: > > > >Why not DT or ACPI for this? > > > We choose to use private data, as pl330 already has struct > dma_pl330_platdata. > Physically DMA share ACPI device with UART, however, BIOS believes DMA and > UART is one device. > We can't

Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-11 Thread Vinod Koul
On Thu, Dec 10, 2015 at 06:38:09AM +, Wang, Annie wrote: > > > >Why not DT or ACPI for this? > > > We choose to use private data, as pl330 already has struct > dma_pl330_platdata. > Physically DMA share ACPI device with UART, however, BIOS believes DMA and > UART is one device. > We can't

Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-11 Thread Andy Shevchenko
On Fri, Dec 11, 2015 at 11:29 AM, Vinod Koul wrote: > On Thu, Dec 10, 2015 at 06:38:09AM +, Wang, Annie wrote: >> > >> >Why not DT or ACPI for this? >> > >> We choose to use private data, as pl330 already has struct >> dma_pl330_platdata. >> Physically DMA share ACPI

RE: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-09 Thread Wang, Annie
l.org; linux- >ser...@vger.kernel.org; dmaeng...@vger.kernel.org; iommu@lists.linux- >foundation.org; Borislav Petkov; Huang, Ray; Wan, Vincent; Xue, Ken; Li, Tony >Subject: Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data > >On Fri, Dec 04, 2015 at 11:24:21AM +0800, Wang Ho

Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-09 Thread Vinod Koul
On Fri, Dec 04, 2015 at 11:24:21AM +0800, Wang Hongcheng wrote: > has_no_cap_mask means this device has no preset cap mask. > mcbuf_sz means bytes to allocate for MC buffer. MC ? > flags is for irq sharing, default is non-shared, in AMD > Carrizo, pl330 shares IRQ with its corresponding UART

Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-09 Thread Vinod Koul
On Fri, Dec 04, 2015 at 11:24:21AM +0800, Wang Hongcheng wrote: > has_no_cap_mask means this device has no preset cap mask. > mcbuf_sz means bytes to allocate for MC buffer. MC ? > flags is for irq sharing, default is non-shared, in AMD > Carrizo, pl330 shares IRQ with its corresponding UART

RE: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-09 Thread Wang, Annie
l.org; linux- >ser...@vger.kernel.org; dmaeng...@vger.kernel.org; iommu@lists.linux- >foundation.org; Borislav Petkov; Huang, Ray; Wan, Vincent; Xue, Ken; Li, Tony >Subject: Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data > >On Fri, Dec 04, 2015 at 11:24:21AM +0800, Wang Ho

[PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-03 Thread Wang Hongcheng
has_no_cap_mask means this device has no preset cap mask. mcbuf_sz means bytes to allocate for MC buffer. flags is for irq sharing, default is non-shared, in AMD Carrizo, pl330 shares IRQ with its corresponding UART device. Signed-off-by: Wang Hongcheng --- drivers/acpi/acpi_apd.c| 13

[PATCH 4/9] dmaengine: pl330: add new items for pl330 private data

2015-12-03 Thread Wang Hongcheng
has_no_cap_mask means this device has no preset cap mask. mcbuf_sz means bytes to allocate for MC buffer. flags is for irq sharing, default is non-shared, in AMD Carrizo, pl330 shares IRQ with its corresponding UART device. Signed-off-by: Wang Hongcheng ---