Re: [PATCH 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-07 Thread Maxime Ripard
Hi, On Tue, Oct 04, 2016 at 10:28:18AM +0800, Chen-Yu Tsai wrote: > > if (sunxi_pctrl_has_drive_prop(node)) { > > int drive = sunxi_pctrl_parse_drive_prop(node); > > - if (drive < 0) > > + if (drive < 0) { > > + ret = -EINVA

Re: [PATCH 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-03 Thread Chen-Yu Tsai
On Mon, Oct 3, 2016 at 6:21 PM, Maxime Ripard wrote: > Even though the our binding had the assumption that the allwinner,pull and > allwinner,drive properties were optional, the code never took that into > account. > > Fix that. > > Signed-off-by: Maxime Ripard > --- > drivers/pinctrl/sunxi/pinc

[PATCH 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-03 Thread Maxime Ripard
Even though the our binding had the assumption that the allwinner,pull and allwinner,drive properties were optional, the code never took that into account. Fix that. Signed-off-by: Maxime Ripard --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 50 +++- 1 file changed, 35 inse