Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-09-03 Thread maowenan
On 2019/9/3 14:58, Tim Froidcoeur wrote: > Hi, > > I also tried to reproduce this in a targeted way, and run into the > same difficulty as you: satisfying the first condition “ > (sk->sk_wmem_queued >> 1) > limit “. > I will not have bandwidth the coming days to try and reproduce it in > this wa

Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-09-02 Thread Tim Froidcoeur
Hi, I also tried to reproduce this in a targeted way, and run into the same difficulty as you: satisfying the first condition “ (sk->sk_wmem_queued >> 1) > limit “. I will not have bandwidth the coming days to try and reproduce it in this way. Maybe simply forcing a very small send buffer using sy

Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread Sasha Levin
On Sat, Aug 31, 2019 at 03:14:35PM +0200, Matthieu Baerts wrote: Hi Sasha, Thank you for your reply! On 31/08/2019 14:20, Sasha Levin wrote: On Sat, Aug 24, 2019 at 08:03:51AM +0200, Tim Froidcoeur wrote: Commit 8c3088f895a0 ("tcp: be more careful in tcp_fragment()") triggers following stack

Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread Matthieu Baerts
Hi Sasha, Thank you for your reply! On 31/08/2019 14:20, Sasha Levin wrote: > On Sat, Aug 24, 2019 at 08:03:51AM +0200, Tim Froidcoeur wrote: >> Commit 8c3088f895a0 ("tcp: be more careful in tcp_fragment()") >> triggers following stack trace: >> >> [25244.848046] kernel BUG at ./include/linux/skb

Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread Sasha Levin
On Sat, Aug 24, 2019 at 08:03:51AM +0200, Tim Froidcoeur wrote: Commit 8c3088f895a0 ("tcp: be more careful in tcp_fragment()") triggers following stack trace: [25244.848046] kernel BUG at ./include/linux/skbuff.h:1406! [25244.859335] RIP: 0010:skb_queue_prev+0x9/0xc [25244.888167] Call Trace: [2

RE: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread maowenan
Tim Can you share the reproduce steps for this issue? C or syzkaller is ok. Thanks a lot.

Recall: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread maowenan
maowenan would like to recall the message, "[PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue".

RE: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread maowenan
[] skb_peek_tail include/linux/skbuff.h:1516 [inline] [] tcp_write_queue_tail include/net/tcp.h:1478 [inline] [] tcp_rtx_queue_tail include/net/tcp.h:1543 [inline] [] tcp_fragment+0xc64/0xce8 net/ipv4/tcp_output.c:1175 [] tcp_write_wakeup+0x3f8/0x4a0 net/ipv4/tcp_output.c:3496 [] tcp_send_probe0+0x

Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-30 Thread David Miller
From: Christoph Paasch Date: Fri, 30 Aug 2019 16:26:57 -0700 > (I don't see it in the stable-queue) I don't handle any stable branch before the most recent two, so this isn't my territory.

Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-30 Thread Christoph Paasch
Hello, On 24/08/19 - 15:05:20, Jonathan Lemon wrote: > > > On 23 Aug 2019, at 23:03, Tim Froidcoeur wrote: > > > Commit 8c3088f895a0 ("tcp: be more careful in tcp_fragment()") > > triggers following stack trace: > > > > [25244.848046] kernel BUG at ./include/linux/skbuff.h:1406! > > [25244.8593

Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-24 Thread Jonathan Lemon
On 23 Aug 2019, at 23:03, Tim Froidcoeur wrote: > Commit 8c3088f895a0 ("tcp: be more careful in tcp_fragment()") > triggers following stack trace: > > [25244.848046] kernel BUG at ./include/linux/skbuff.h:1406! > [25244.859335] RIP: 0010:skb_queue_prev+0x9/0xc > [25244.888167] Call Trace: > [25

[PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-23 Thread Tim Froidcoeur
Commit 8c3088f895a0 ("tcp: be more careful in tcp_fragment()") triggers following stack trace: [25244.848046] kernel BUG at ./include/linux/skbuff.h:1406! [25244.859335] RIP: 0010:skb_queue_prev+0x9/0xc [25244.888167] Call Trace: [25244.889182] [25244.890001] tcp_fragment+0x9c/0x2cf [25244.8912