Re: [PATCH 4.14 09/89] net: Prevent invalid access to skb->prev in __qdisc_drop_all

2018-12-14 Thread Christoph Paasch
On 14/12/18 - 11:05:30, David Miller wrote: > From: Christoph Paasch > Date: Fri, 14 Dec 2018 07:52:26 -0800 > > > I don't think this patch needs to be backported. I haven't hit this panic on > > v4.14.x (although, I only have been using v4.14.79 for now - not yet the > > latest one). And the

Re: [PATCH 4.14 09/89] net: Prevent invalid access to skb->prev in __qdisc_drop_all

2018-12-14 Thread David Miller
From: Christoph Paasch Date: Fri, 14 Dec 2018 07:52:26 -0800 > I don't think this patch needs to be backported. I haven't hit this panic on > v4.14.x (although, I only have been using v4.14.79 for now - not yet the > latest one). And the commits that seem to have introduced the issue haven't >

Re: [PATCH 4.14 09/89] net: Prevent invalid access to skb->prev in __qdisc_drop_all

2018-12-14 Thread Christoph Paasch
Hello Greg, On 14/12/18 - 12:59:22, Greg Kroah-Hartman wrote: > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Christoph Paasch > > [ Upstream commit 9410d386d0a829ace9558336263086c2fbbe8aed ] > > __qdisc_drop_all() accesses

Re: [PATCH 4.14 09/89] net: Prevent invalid access to skb->prev in __qdisc_drop_all

2018-12-14 Thread Christoph Paasch
On 14/12/18 - 07:52:26, Christoph Paasch wrote: > Hello Greg, > > On 14/12/18 - 12:59:22, Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Christoph Paasch > > > > [ Upstream commit

Re: [PATCH 4.14 09/89] net: Prevent invalid access to skb->prev in __qdisc_drop_all

2018-12-14 Thread Eric Dumazet
On Fri, Dec 14, 2018 at 7:54 AM Christoph Paasch wrote: > To clarify: Backport to v4.19.x is needed. The backport to v4.14 and older > should not be needed. Sure, but this does not cause any harm. No further action needed :)

[PATCH 4.14 09/89] net: Prevent invalid access to skb->prev in __qdisc_drop_all

2018-12-14 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Christoph Paasch [ Upstream commit 9410d386d0a829ace9558336263086c2fbbe8aed ] __qdisc_drop_all() accesses skb->prev to get to the tail of the segment-list. With commit 68d2f84a1368 ("net: