Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-06 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 08:00:20PM +0100, Borislav Petkov wrote: > On Wed, Dec 05, 2018 at 06:26:24PM +0200, Jari Ruusu wrote: > > That same race appears to be present in older kernel branches also. > > The context is sligthly different, so the patch for 4.14 does not > > apply cleanly to older

Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-06 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 08:00:20PM +0100, Borislav Petkov wrote: > On Wed, Dec 05, 2018 at 06:26:24PM +0200, Jari Ruusu wrote: > > That same race appears to be present in older kernel branches also. > > The context is sligthly different, so the patch for 4.14 does not > > apply cleanly to older

Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 06:26:24PM +0200, Jari Ruusu wrote: > That same race appears to be present in older kernel branches also. > The context is sligthly different, so the patch for 4.14 does not > apply cleanly to older kernels. For 4.9 branch, this edit works: You could take the upstream one,

Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 06:26:24PM +0200, Jari Ruusu wrote: > That same race appears to be present in older kernel branches also. > The context is sligthly different, so the patch for 4.14 does not > apply cleanly to older kernels. For 4.9 branch, this edit works: You could take the upstream one,

Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-05 Thread Jari Ruusu
Greg Kroah-Hartman wrote: > commit 68239654acafe6aad5a3c1dc7237e60accfebc03 upstream. > > The sequence > > fpu->initialized = 1; /* step A */ > preempt_disable();/* step B */ > fpu__restore(fpu); > preempt_enable(); > > in __fpu__restore_sig() is racy in regard to a

Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-05 Thread Jari Ruusu
Greg Kroah-Hartman wrote: > commit 68239654acafe6aad5a3c1dc7237e60accfebc03 upstream. > > The sequence > > fpu->initialized = 1; /* step A */ > preempt_disable();/* step B */ > fpu__restore(fpu); > preempt_enable(); > > in __fpu__restore_sig() is racy in regard to a

[PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-04 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior commit 68239654acafe6aad5a3c1dc7237e60accfebc03 upstream. The sequence fpu->initialized = 1; /* step A */ preempt_disable();/* step B */

[PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-04 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior commit 68239654acafe6aad5a3c1dc7237e60accfebc03 upstream. The sequence fpu->initialized = 1; /* step A */ preempt_disable();/* step B */