Re: [PATCH 4.14 61/81] ALSA: seq: Protect in-kernel ioctl calls with mutex

2019-06-13 Thread Sasha Levin
On Thu, Jun 13, 2019 at 05:44:15PM +0200, Takashi Iwai wrote: On Thu, 13 Jun 2019 17:39:46 +0200, Sasha Levin wrote: On Thu, Jun 13, 2019 at 11:13:55AM +0200, Takashi Iwai wrote: >On Thu, 13 Jun 2019 11:11:22 +0200, >Greg Kroah-Hartman wrote: >> >> On Thu, Jun 13, 2019 at 11:02:54AM +0200, Taka

[PATCH 4.14 61/81] ALSA: seq: Protect in-kernel ioctl calls with mutex

2019-06-13 Thread Greg Kroah-Hartman
[ Upstream commit feb689025fbb6f0aa6297d3ddf97de945ea4ad32 ] ALSA OSS sequencer calls the ioctl function indirectly via snd_seq_kernel_client_ctl(). While we already applied the protection against races between the normal ioctls and writes via the client's ioctl_mutex, this code path was left unt

Re: [PATCH 4.14 61/81] ALSA: seq: Protect in-kernel ioctl calls with mutex

2019-06-13 Thread Takashi Iwai
On Thu, 13 Jun 2019 10:33:44 +0200, Greg Kroah-Hartman wrote: > > [ Upstream commit feb689025fbb6f0aa6297d3ddf97de945ea4ad32 ] > > ALSA OSS sequencer calls the ioctl function indirectly via > snd_seq_kernel_client_ctl(). While we already applied the protection > against races between the normal

Re: [PATCH 4.14 61/81] ALSA: seq: Protect in-kernel ioctl calls with mutex

2019-06-13 Thread Greg Kroah-Hartman
On Thu, Jun 13, 2019 at 11:02:54AM +0200, Takashi Iwai wrote: > On Thu, 13 Jun 2019 10:33:44 +0200, > Greg Kroah-Hartman wrote: > > > > [ Upstream commit feb689025fbb6f0aa6297d3ddf97de945ea4ad32 ] > > > > ALSA OSS sequencer calls the ioctl function indirectly via > > snd_seq_kernel_client_ctl().

Re: [PATCH 4.14 61/81] ALSA: seq: Protect in-kernel ioctl calls with mutex

2019-06-13 Thread Takashi Iwai
On Thu, 13 Jun 2019 11:11:22 +0200, Greg Kroah-Hartman wrote: > > On Thu, Jun 13, 2019 at 11:02:54AM +0200, Takashi Iwai wrote: > > On Thu, 13 Jun 2019 10:33:44 +0200, > > Greg Kroah-Hartman wrote: > > > > > > [ Upstream commit feb689025fbb6f0aa6297d3ddf97de945ea4ad32 ] > > > > > > ALSA OSS sequ

Re: [PATCH 4.14 61/81] ALSA: seq: Protect in-kernel ioctl calls with mutex

2019-06-13 Thread Takashi Iwai
On Thu, 13 Jun 2019 17:39:46 +0200, Sasha Levin wrote: > > On Thu, Jun 13, 2019 at 11:13:55AM +0200, Takashi Iwai wrote: > >On Thu, 13 Jun 2019 11:11:22 +0200, > >Greg Kroah-Hartman wrote: > >> > >> On Thu, Jun 13, 2019 at 11:02:54AM +0200, Takashi Iwai wrote: > >> > On Thu, 13 Jun 2019 10:33:44 +

Re: [PATCH 4.14 61/81] ALSA: seq: Protect in-kernel ioctl calls with mutex

2019-06-13 Thread Sasha Levin
On Thu, Jun 13, 2019 at 11:13:55AM +0200, Takashi Iwai wrote: On Thu, 13 Jun 2019 11:11:22 +0200, Greg Kroah-Hartman wrote: On Thu, Jun 13, 2019 at 11:02:54AM +0200, Takashi Iwai wrote: > On Thu, 13 Jun 2019 10:33:44 +0200, > Greg Kroah-Hartman wrote: > > > > [ Upstream commit feb689025fbb6f0aa