Re: [PATCH 4.19 001/106] tpm: use tpm_try_get_ops() in tpm-sysfs.c.

2019-10-08 Thread Jarkko Sakkinen
On Tue, Oct 08, 2019 at 02:51:20PM +0200, Pavel Machek wrote: > For example this did not have any locking, and is now protected by > > get_device(>dev); > > down_read(>ops_sem); > > . Is that intended? Is this known to fix any bugs? It is, sysfs code can otherwise race when ops

Re: [PATCH 4.19 001/106] tpm: use tpm_try_get_ops() in tpm-sysfs.c.

2019-10-08 Thread Pavel Machek
On Sun 2019-10-06 19:20:07, Greg Kroah-Hartman wrote: > From: Jarkko Sakkinen > > commit 2677ca98ae377517930c183248221f69f771c921 upstream > > Use tpm_try_get_ops() in tpm-sysfs.c so that we can consider moving > other decorations (locking, localities, power management for example) > inside it.

[PATCH 4.19 001/106] tpm: use tpm_try_get_ops() in tpm-sysfs.c.

2019-10-06 Thread Greg Kroah-Hartman
From: Jarkko Sakkinen commit 2677ca98ae377517930c183248221f69f771c921 upstream Use tpm_try_get_ops() in tpm-sysfs.c so that we can consider moving other decorations (locking, localities, power management for example) inside it. This direction can be of course taken only after other call sites