Re: [PATCH 4.19 01/51] ethtool: fix potential userspace buffer overflow

2019-06-10 Thread Greg Kroah-Hartman
On Mon, Jun 10, 2019 at 10:42:29AM +0200, Michal Kubecek wrote: > On Mon, Jun 10, 2019 at 10:21:12AM +0200, Pavel Machek wrote: > > Hi! > > > > > From: Vivien Didelot > > > > > > [ Upstream commit 0ee4e76937d69128a6a66861ba393ebdc2ffc8a2 ] > > > > > > ethtool_get_regs() allocates a buffer of si

Re: [PATCH 4.19 01/51] ethtool: fix potential userspace buffer overflow

2019-06-10 Thread Michal Kubecek
On Mon, Jun 10, 2019 at 10:21:12AM +0200, Pavel Machek wrote: > Hi! > > > From: Vivien Didelot > > > > [ Upstream commit 0ee4e76937d69128a6a66861ba393ebdc2ffc8a2 ] > > > > ethtool_get_regs() allocates a buffer of size ops->get_regs_len(), > > and pass it to the kernel driver via ops->get_regs()

Re: [PATCH 4.19 01/51] ethtool: fix potential userspace buffer overflow

2019-06-10 Thread Pavel Machek
Hi! > From: Vivien Didelot > > [ Upstream commit 0ee4e76937d69128a6a66861ba393ebdc2ffc8a2 ] > > ethtool_get_regs() allocates a buffer of size ops->get_regs_len(), > and pass it to the kernel driver via ops->get_regs() for filling. > > There is no restriction about what the kernel drivers can o

[PATCH 4.19 01/51] ethtool: fix potential userspace buffer overflow

2019-06-09 Thread Greg Kroah-Hartman
From: Vivien Didelot [ Upstream commit 0ee4e76937d69128a6a66861ba393ebdc2ffc8a2 ] ethtool_get_regs() allocates a buffer of size ops->get_regs_len(), and pass it to the kernel driver via ops->get_regs() for filling. There is no restriction about what the kernel drivers can or cannot do with the