Re: [PATCH 4.19 073/168] media: firewire: Using uninitialized values in node_probe()

2020-08-18 Thread Greg Kroah-Hartman
On Tue, Aug 18, 2020 at 11:34:53PM +0200, Pavel Machek wrote: > Hi! > > > From: Dan Carpenter > > > > [ Upstream commit 2505a210fc126599013aec2be741df20aaacc490 ] > > > > If fw_csr_string() returns -ENOENT, then "name" is uninitialized. So > > then the "strlen(model_names[i]) <= name_len" is

Re: [PATCH 4.19 073/168] media: firewire: Using uninitialized values in node_probe()

2020-08-18 Thread Pavel Machek
Hi! > From: Dan Carpenter > > [ Upstream commit 2505a210fc126599013aec2be741df20aaacc490 ] > > If fw_csr_string() returns -ENOENT, then "name" is uninitialized. So > then the "strlen(model_names[i]) <= name_len" is true because strlen() > is unsigned and -ENOENT is type promoted to a very

[PATCH 4.19 073/168] media: firewire: Using uninitialized values in node_probe()

2020-08-17 Thread Greg Kroah-Hartman
From: Dan Carpenter [ Upstream commit 2505a210fc126599013aec2be741df20aaacc490 ] If fw_csr_string() returns -ENOENT, then "name" is uninitialized. So then the "strlen(model_names[i]) <= name_len" is true because strlen() is unsigned and -ENOENT is type promoted to a very high positive value.