Re: [PATCH 4.19 1/7] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210

2020-09-01 Thread Greg KH
On Fri, Aug 28, 2020 at 04:23:48PM -0700, Sowjanya Komatineni wrote: > > On 8/28/20 4:15 PM, Sasha Levin wrote: > > On Fri, Aug 28, 2020 at 03:25:11PM -0700, Sowjanya Komatineni wrote: > > > commit b5a84ecf025a ("mmc: tegra: Add Tegra210 support") > > > > What does this line above represent? > >

Re: [PATCH 4.19 1/7] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210

2020-08-28 Thread Sowjanya Komatineni
On 8/28/20 4:15 PM, Sasha Levin wrote: On Fri, Aug 28, 2020 at 03:25:11PM -0700, Sowjanya Komatineni wrote: commit b5a84ecf025a ("mmc: tegra: Add Tegra210 support") What does this line above represent? SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK is set incorrectly in above commit when Tegra210

Re: [PATCH 4.19 1/7] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210

2020-08-28 Thread Sasha Levin
On Fri, Aug 28, 2020 at 03:25:11PM -0700, Sowjanya Komatineni wrote: commit b5a84ecf025a ("mmc: tegra: Add Tegra210 support") What does this line above represent? SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK is set for Tegra210 from the beginning of Tegra210 support in the driver. Tegra210 SDMMC

[PATCH 4.19 1/7] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210

2020-08-28 Thread Sowjanya Komatineni
commit b5a84ecf025a ("mmc: tegra: Add Tegra210 support") SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK is set for Tegra210 from the beginning of Tegra210 support in the driver. Tegra210 SDMMC hardware by default uses timeout clock (TMCLK) instead of SDCLK and this quirk should not be set. So, this patch