Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 6:57 PM Pavel Machek wrote: > On Tue 2020-05-05 11:32:27, Sasha Levin wrote: > > On Tue, May 05, 2020 at 05:05:37PM +0300, Andy Shevchenko wrote: ... > > I'm a bit confused about this too. Maybe it's too early in the morning, > > so I wrote this little test program: > > >

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Pavel Machek
On Tue 2020-05-05 11:32:27, Sasha Levin wrote: > On Tue, May 05, 2020 at 05:05:37PM +0300, Andy Shevchenko wrote: > > On Tue, May 5, 2020 at 4:37 PM Pavel Machek wrote: > > > On Tue 2020-05-05 16:19:11, Andy Shevchenko wrote: > > > > On Tue, May 5, 2020 at 3:58 PM Pavel Machek wrote: > > > > > On

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Sasha Levin
On Tue, May 05, 2020 at 05:05:37PM +0300, Andy Shevchenko wrote: On Tue, May 5, 2020 at 4:37 PM Pavel Machek wrote: On Tue 2020-05-05 16:19:11, Andy Shevchenko wrote: > On Tue, May 5, 2020 at 3:58 PM Pavel Machek wrote: > > On Tue 2020-05-05 15:51:16, Andy Shevchenko wrote: > > > On Tue, May 5

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Pavel Machek
On Tue 2020-05-05 17:05:37, Andy Shevchenko wrote: > On Tue, May 5, 2020 at 4:37 PM Pavel Machek wrote: > > On Tue 2020-05-05 16:19:11, Andy Shevchenko wrote: > > > On Tue, May 5, 2020 at 3:58 PM Pavel Machek wrote: > > > > On Tue 2020-05-05 15:51:16, Andy Shevchenko wrote: > > > > > On Tue, May

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 4:37 PM Pavel Machek wrote: > On Tue 2020-05-05 16:19:11, Andy Shevchenko wrote: > > On Tue, May 5, 2020 at 3:58 PM Pavel Machek wrote: > > > On Tue 2020-05-05 15:51:16, Andy Shevchenko wrote: > > > > On Tue, May 5, 2020 at 3:37 PM Pavel Machek wrote: > > > > > > So, to th

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Pavel Machek
On Tue 2020-05-05 16:19:11, Andy Shevchenko wrote: > On Tue, May 5, 2020 at 3:58 PM Pavel Machek wrote: > > On Tue 2020-05-05 15:51:16, Andy Shevchenko wrote: > > > On Tue, May 5, 2020 at 3:37 PM Pavel Machek wrote: > > > > > So, to the point, the conditional of checking the thread to be > > > >

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 3:58 PM Pavel Machek wrote: > On Tue 2020-05-05 15:51:16, Andy Shevchenko wrote: > > On Tue, May 5, 2020 at 3:37 PM Pavel Machek wrote: > > > > So, to the point, the conditional of checking the thread to be stopped > > > > being > > > > first part of conjunction logic prev

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Pavel Machek
On Tue 2020-05-05 15:51:16, Andy Shevchenko wrote: > On Tue, May 5, 2020 at 3:37 PM Pavel Machek wrote: > > > So, to the point, the conditional of checking the thread to be stopped > > > being > > > first part of conjunction logic prevents to check iterations. Thus, we > > > have to > > > always

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 3:37 PM Pavel Machek wrote: > > So, to the point, the conditional of checking the thread to be stopped being > > first part of conjunction logic prevents to check iterations. Thus, we have > > to > > always check both conditions to be able to stop after given > > iterations

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Pavel Machek
Hi! > So, to the point, the conditional of checking the thread to be stopped being > first part of conjunction logic prevents to check iterations. Thus, we have to > always check both conditions to be able to stop after given > iterations. I ... don't understand. AFAICT the code is equivalent. Bo

[PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-04 Thread Greg Kroah-Hartman
From: Andy Shevchenko commit b9f960201249f20deea586b4ec814669b4c6b1c0 upstream. Under some circumstances, i.e. when test is still running and about to time out and user runs, for example, grep -H . /sys/module/dmatest/parameters/* the iterations parameter is not respected and test is g