Re: [PATCH 4.19 287/346] crypto: ecdh - avoid unaligned accesses in ecdh_set_secret()

2021-01-02 Thread Ard Biesheuvel
On Thu, 31 Dec 2020 at 21:09, Pavel Machek wrote: > > Hi! > > > ecdh_set_secret() casts a void* pointer to a const u64* in order to > > feed it into ecc_is_key_valid(). This is not generally permitted by > > the C standard, and leads to actual misalignment faults on ARMv6 > > cores. In some

Re: [PATCH 4.19 287/346] crypto: ecdh - avoid unaligned accesses in ecdh_set_secret()

2020-12-31 Thread Pavel Machek
Hi! > ecdh_set_secret() casts a void* pointer to a const u64* in order to > feed it into ecc_is_key_valid(). This is not generally permitted by > the C standard, and leads to actual misalignment faults on ARMv6 > cores. In some cases, these are fixed up in software, but this still > leads to

[PATCH 4.19 287/346] crypto: ecdh - avoid unaligned accesses in ecdh_set_secret()

2020-12-28 Thread Greg Kroah-Hartman
From: Ard Biesheuvel commit 17858b140bf49961b71d4e73f1c3ea9bc8e7dda0 upstream. ecdh_set_secret() casts a void* pointer to a const u64* in order to feed it into ecc_is_key_valid(). This is not generally permitted by the C standard, and leads to actual misalignment faults on ARMv6 cores. In some