Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-23 Thread gre...@linuxfoundation.org
On Sat, Dec 23, 2017 at 03:53:57PM +, Ghorai, Sukumar wrote: > >> > included in 4.14-rc1, so something needs to be done in Linus's tree > >> > to resolve this issue, otherwise people will hit this as a > >> > regression when moving to 4.14 or newer. > >> > >> Well, I wouldn't object to

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-23 Thread gre...@linuxfoundation.org
On Sat, Dec 23, 2017 at 03:53:57PM +, Ghorai, Sukumar wrote: > >> > included in 4.14-rc1, so something needs to be done in Linus's tree > >> > to resolve this issue, otherwise people will hit this as a > >> > regression when moving to 4.14 or newer. > >> > >> Well, I wouldn't object to

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-23 Thread Ghorai, Sukumar
>> > included in 4.14-rc1, so something needs to be done in Linus's tree >> > to resolve this issue, otherwise people will hit this as a >> > regression when moving to 4.14 or newer. >> >> Well, I wouldn't object to reverting it in Linus' tree too, since >> AFAIK, this is something that can be

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-23 Thread Ghorai, Sukumar
>> > included in 4.14-rc1, so something needs to be done in Linus's tree >> > to resolve this issue, otherwise people will hit this as a >> > regression when moving to 4.14 or newer. >> >> Well, I wouldn't object to reverting it in Linus' tree too, since >> AFAIK, this is something that can be

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-23 Thread gre...@linuxfoundation.org
On Fri, Dec 22, 2017 at 09:37:48AM -0800, Brian Norris wrote: > > included in 4.14-rc1, so something needs to be done in Linus's tree to > > resolve this issue, otherwise people will hit this as a regression when > > moving to 4.14 or newer. > > Well, I wouldn't object to reverting it in Linus'

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-23 Thread gre...@linuxfoundation.org
On Fri, Dec 22, 2017 at 09:37:48AM -0800, Brian Norris wrote: > > included in 4.14-rc1, so something needs to be done in Linus's tree to > > resolve this issue, otherwise people will hit this as a regression when > > moving to 4.14 or newer. > > Well, I wouldn't object to reverting it in Linus'

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-22 Thread Brian Norris
On Fri, Dec 22, 2017 at 08:48:28AM +0100, Greg Kroah-Hartman wrote: > I've reverted this from 4.4 and 4.9-stable, but note that this was Thanks! > included in 4.14-rc1, so something needs to be done in Linus's tree to > resolve this issue, otherwise people will hit this as a regression when >

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-22 Thread Brian Norris
On Fri, Dec 22, 2017 at 08:48:28AM +0100, Greg Kroah-Hartman wrote: > I've reverted this from 4.4 and 4.9-stable, but note that this was Thanks! > included in 4.14-rc1, so something needs to be done in Linus's tree to > resolve this issue, otherwise people will hit this as a regression when >

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread gre...@linuxfoundation.org
On Thu, Dec 21, 2017 at 01:39:41PM -0800, Guenter Roeck wrote: > On Thu, Dec 21, 2017 at 09:50:57PM +0100, gre...@linuxfoundation.org wrote: > > On Thu, Dec 21, 2017 at 09:46:18PM +0100, gre...@linuxfoundation.org wrote: > > > On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote: > > > >

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread gre...@linuxfoundation.org
On Thu, Dec 21, 2017 at 01:39:41PM -0800, Guenter Roeck wrote: > On Thu, Dec 21, 2017 at 09:50:57PM +0100, gre...@linuxfoundation.org wrote: > > On Thu, Dec 21, 2017 at 09:46:18PM +0100, gre...@linuxfoundation.org wrote: > > > On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote: > > > >

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Guenter Roeck
On Thu, Dec 21, 2017 at 09:50:57PM +0100, gre...@linuxfoundation.org wrote: > On Thu, Dec 21, 2017 at 09:46:18PM +0100, gre...@linuxfoundation.org wrote: > > On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote: > > > On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote: > > > >

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Guenter Roeck
On Thu, Dec 21, 2017 at 09:50:57PM +0100, gre...@linuxfoundation.org wrote: > On Thu, Dec 21, 2017 at 09:46:18PM +0100, gre...@linuxfoundation.org wrote: > > On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote: > > > On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote: > > > >

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread gre...@linuxfoundation.org
On Thu, Dec 21, 2017 at 09:46:18PM +0100, gre...@linuxfoundation.org wrote: > On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote: > > On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote: > > > On Thu, Dec 21, 2017 at 07:05:03PM +, Ghorai, Sukumar wrote: > > > > >>On Thu,

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread gre...@linuxfoundation.org
On Thu, Dec 21, 2017 at 09:46:18PM +0100, gre...@linuxfoundation.org wrote: > On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote: > > On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote: > > > On Thu, Dec 21, 2017 at 07:05:03PM +, Ghorai, Sukumar wrote: > > > > >>On Thu,

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread gre...@linuxfoundation.org
On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote: > On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote: > > On Thu, Dec 21, 2017 at 07:05:03PM +, Ghorai, Sukumar wrote: > > > >>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: > > > >> Bug: platform can't

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread gre...@linuxfoundation.org
On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote: > On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote: > > On Thu, Dec 21, 2017 at 07:05:03PM +, Ghorai, Sukumar wrote: > > > >>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: > > > >> Bug: platform can't

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>> I understand this feature is creating instability in other area. >> However - 1. the problem will remain same when enable the usb-wakeup >> feature form kernel or user-space or udev rule, and as long LE device is >connected. > >There is a slight difference of leaving the decision to the user

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>> I understand this feature is creating instability in other area. >> However - 1. the problem will remain same when enable the usb-wakeup >> feature form kernel or user-space or udev rule, and as long LE device is >connected. > >There is a slight difference of leaving the decision to the user

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Guenter Roeck
On Thu, Dec 21, 2017 at 07:23:27PM +, Ghorai, Sukumar wrote: > >> >Could you ever? If not, that looks like a feature request to me... > >> Agree, feature request... however we need this feature for rapid use of > >Bluetooth LE devices. > > > >Is that what -stable is for now? For getting your

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Guenter Roeck
On Thu, Dec 21, 2017 at 07:23:27PM +, Ghorai, Sukumar wrote: > >> >Could you ever? If not, that looks like a feature request to me... > >> Agree, feature request... however we need this feature for rapid use of > >Bluetooth LE devices. > > > >Is that what -stable is for now? For getting your

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Guenter Roeck
On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote: > On Thu, Dec 21, 2017 at 07:05:03PM +, Ghorai, Sukumar wrote: > > >>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: > > >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O > > >> device

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Guenter Roeck
On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote: > On Thu, Dec 21, 2017 at 07:05:03PM +, Ghorai, Sukumar wrote: > > >>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: > > >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O > > >> device

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>> >Could you ever? If not, that looks like a feature request to me... >> Agree, feature request... however we need this feature for rapid use of >Bluetooth LE devices. > >Is that what -stable is for now? For getting your pet feature enabled more >quickly? I thought that's what Linaro was for, or

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>> >Could you ever? If not, that looks like a feature request to me... >> Agree, feature request... however we need this feature for rapid use of >Bluetooth LE devices. > >Is that what -stable is for now? For getting your pet feature enabled more >quickly? I thought that's what Linaro was for, or

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Brian Norris
On Thu, Dec 21, 2017 at 07:05:03PM +, Ghorai, Sukumar wrote: > >>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: > >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O > >> device connected. > > > >Could you ever? If not, that looks like a feature request

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Brian Norris
On Thu, Dec 21, 2017 at 07:05:03PM +, Ghorai, Sukumar wrote: > >>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: > >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O > >> device connected. > > > >Could you ever? If not, that looks like a feature request

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O >> device connected. > >Could you ever? If not, that looks like a feature request to me... Agree, feature request... however we need this feature for rapid

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O >> device connected. > >Could you ever? If not, that looks like a feature request to me... Agree, feature request... however we need this feature for rapid

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O >> device connected. > >Could you ever? If not, that looks like a feature request to me... Agree, feature request... > >Brian

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O >> device connected. > >Could you ever? If not, that looks like a feature request to me... Agree, feature request... > >Brian

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Brian Norris
On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: > Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O device > connected. Could you ever? If not, that looks like a feature request to me... Brian

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Brian Norris
On Thu, Dec 21, 2017 at 06:52:31PM +, Ghorai, Sukumar wrote: > Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O device > connected. Could you ever? If not, that looks like a feature request to me... Brian

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>> Linus' tree is broken in 2 ways: >> >> 1. It includes this patch: >> "Bluetooth: btusb: fix QCA Rome suspend/resume" >> which is wrong, and we're on our way to reverting it upstream and >> backporting that to -stable. >> >> 2. It includes $subject patch. I'm not quite so sure, but I believe >>

RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Ghorai, Sukumar
>> Linus' tree is broken in 2 ways: >> >> 1. It includes this patch: >> "Bluetooth: btusb: fix QCA Rome suspend/resume" >> which is wrong, and we're on our way to reverting it upstream and >> backporting that to -stable. >> >> 2. It includes $subject patch. I'm not quite so sure, but I believe >>

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Guenter Roeck
On Thu, Dec 21, 2017 at 09:20:51AM -0800, Brian Norris wrote: > On Thu, Dec 21, 2017 at 12:30 AM, gre...@linuxfoundation.org > wrote: > > As Linus's tree is also broken, being bug-compatible here is good, > > right? I can just apply the revert/fix patch when it lands

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Guenter Roeck
On Thu, Dec 21, 2017 at 09:20:51AM -0800, Brian Norris wrote: > On Thu, Dec 21, 2017 at 12:30 AM, gre...@linuxfoundation.org > wrote: > > As Linus's tree is also broken, being bug-compatible here is good, > > right? I can just apply the revert/fix patch when it lands in that > > tree, and all

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Brian Norris
On Thu, Dec 21, 2017 at 12:30 AM, gre...@linuxfoundation.org wrote: > As Linus's tree is also broken, being bug-compatible here is good, > right? I can just apply the revert/fix patch when it lands in that > tree, and all will be ok. > > Or is Linus's tree not broken

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread Brian Norris
On Thu, Dec 21, 2017 at 12:30 AM, gre...@linuxfoundation.org wrote: > As Linus's tree is also broken, being bug-compatible here is good, > right? I can just apply the revert/fix patch when it lands in that > tree, and all will be ok. > > Or is Linus's tree not broken now? Sorry, this whole

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread gre...@linuxfoundation.org
On Wed, Dec 20, 2017 at 11:51:15AM -0800, Brian Norris wrote: > Hi Greg, > > On Mon, Dec 18, 2017 at 04:47:58PM +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > I'm sorry, but I already objected to this one during the discussion

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-21 Thread gre...@linuxfoundation.org
On Wed, Dec 20, 2017 at 11:51:15AM -0800, Brian Norris wrote: > Hi Greg, > > On Mon, Dec 18, 2017 at 04:47:58PM +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > I'm sorry, but I already objected to this one during the discussion

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-20 Thread Brian Norris
+ Kai One more thing: On Wed, Dec 20, 2017 at 11:51:14AM -0800, Brian Norris wrote: > Hi Greg, > > On Mon, Dec 18, 2017 at 04:47:58PM +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > I'm sorry, but I already objected to this

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-20 Thread Brian Norris
+ Kai One more thing: On Wed, Dec 20, 2017 at 11:51:14AM -0800, Brian Norris wrote: > Hi Greg, > > On Mon, Dec 18, 2017 at 04:47:58PM +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > I'm sorry, but I already objected to this

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-20 Thread Brian Norris
Hi Greg, On Mon, Dec 18, 2017 at 04:47:58PM +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. I'm sorry, but I already objected to this one during the discussion here: https://patchwork.kernel.org/patch/10065483/ [PATCH 4.13 03/28]

Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-20 Thread Brian Norris
Hi Greg, On Mon, Dec 18, 2017 at 04:47:58PM +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. I'm sorry, but I already objected to this one during the discussion here: https://patchwork.kernel.org/patch/10065483/ [PATCH 4.13 03/28]

[PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-18 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Sukumar Ghorai commit a0085f2510e8976614ad8f766b209448b385492f upstream. BT-Controller connected as platform non-root-hub device and usb-driver initialize such device

[PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

2017-12-18 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Sukumar Ghorai commit a0085f2510e8976614ad8f766b209448b385492f upstream. BT-Controller connected as platform non-root-hub device and usb-driver initialize such device with wakeup disabled,