Re: [PATCH 4.4 063/114] l2tp: hold socket before dropping lock in l2tp_ip{, 6}_recv()

2018-11-09 Thread Guillaume Nault
On Fri, Nov 09, 2018 at 08:28:56AM -0800, Greg Kroah-Hartman wrote: > On Fri, Nov 09, 2018 at 04:33:32PM +0100, Guillaume Nault wrote: > > On Thu, Nov 08, 2018 at 01:51:18PM -0800, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me > > > know. > >

Re: [PATCH 4.4 063/114] l2tp: hold socket before dropping lock in l2tp_ip{, 6}_recv()

2018-11-09 Thread Greg Kroah-Hartman
On Fri, Nov 09, 2018 at 04:33:32PM +0100, Guillaume Nault wrote: > On Thu, Nov 08, 2018 at 01:51:18PM -0800, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > This patch was partly wrong. Here is the followup fix: > 94d7ee0baa8b ("l2tp:

Re: [PATCH 4.4 063/114] l2tp: hold socket before dropping lock in l2tp_ip{, 6}_recv()

2018-11-09 Thread Guillaume Nault
On Thu, Nov 08, 2018 at 01:51:18PM -0800, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > This patch was partly wrong. Here is the followup fix: 94d7ee0baa8b ("l2tp: hold tunnel socket when handling control frames in l2tp_ip and l2tp_ip6")

[PATCH 4.4 063/114] l2tp: hold socket before dropping lock in l2tp_ip{, 6}_recv()

2018-11-08 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit a3c18422a4b4e108bcf6a2328f48867e1003fd95 ] Socket must be held while under the protection of the l2tp lock; there is no guarantee that sk remains valid after the read_unlock_bh() call