Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-03-22 Thread Greg Kroah-Hartman
On Thu, Mar 22, 2018 at 11:56:35AM -0700, Guenter Roeck wrote: > On Thu, Mar 22, 2018 at 06:52:51PM +0100, Greg Kroah-Hartman wrote: > > [ ... ] > > > > And that't the point to drive home here. If you stay away from updating > > to stable patches, you have a huge boatload of KNOWN SECURITY

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-03-22 Thread Greg Kroah-Hartman
On Thu, Mar 22, 2018 at 11:56:35AM -0700, Guenter Roeck wrote: > On Thu, Mar 22, 2018 at 06:52:51PM +0100, Greg Kroah-Hartman wrote: > > [ ... ] > > > > And that't the point to drive home here. If you stay away from updating > > to stable patches, you have a huge boatload of KNOWN SECURITY

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-03-22 Thread Guenter Roeck
On Thu, Mar 22, 2018 at 06:52:51PM +0100, Greg Kroah-Hartman wrote: [ ... ] > > And that't the point to drive home here. If you stay away from updating > to stable patches, you have a huge boatload of KNOWN SECURITY HOLES in > your product. If you take them, you have the _possiblity_ of some

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-03-22 Thread Guenter Roeck
On Thu, Mar 22, 2018 at 06:52:51PM +0100, Greg Kroah-Hartman wrote: [ ... ] > > And that't the point to drive home here. If you stay away from updating > to stable patches, you have a huge boatload of KNOWN SECURITY HOLES in > your product. If you take them, you have the _possiblity_ of some

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-03-22 Thread Greg Kroah-Hartman
On Wed, Feb 28, 2018 at 11:39:56AM -0800, Brian Norris wrote: > Hi Greg, Hi, Sorry for the delay, wanted to think about this one for a while... > ... > >> > Thanks, but I've now released all of these with this patch committed, so > >> > we are now "bug compatible" :) > > So, is that to say

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-03-22 Thread Greg Kroah-Hartman
On Wed, Feb 28, 2018 at 11:39:56AM -0800, Brian Norris wrote: > Hi Greg, Hi, Sorry for the delay, wanted to think about this one for a while... > ... > >> > Thanks, but I've now released all of these with this patch committed, so > >> > we are now "bug compatible" :) > > So, is that to say

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-28 Thread Brian Norris
Hi Greg, On Sat, Feb 17, 2018 at 7:24 AM, Greg Kroah-Hartman wrote: > On Sat, Feb 17, 2018 at 07:12:17AM -0800, Guenter Roeck wrote: >> On 02/17/2018 05:43 AM, Greg Kroah-Hartman wrote: >> > On Fri, Feb 16, 2018 at 10:52:20AM -0800, Guenter Roeck wrote: >> > > On Fri,

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-28 Thread Brian Norris
Hi Greg, On Sat, Feb 17, 2018 at 7:24 AM, Greg Kroah-Hartman wrote: > On Sat, Feb 17, 2018 at 07:12:17AM -0800, Guenter Roeck wrote: >> On 02/17/2018 05:43 AM, Greg Kroah-Hartman wrote: >> > On Fri, Feb 16, 2018 at 10:52:20AM -0800, Guenter Roeck wrote: >> > > On Fri, Feb 16, 2018 at 10:10:44AM

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-17 Thread Greg Kroah-Hartman
On Sat, Feb 17, 2018 at 07:12:17AM -0800, Guenter Roeck wrote: > On 02/17/2018 05:43 AM, Greg Kroah-Hartman wrote: > > On Fri, Feb 16, 2018 at 10:52:20AM -0800, Guenter Roeck wrote: > > > On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: > > > > On Fri, Feb 16, 2018 at 07:48:50AM

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-17 Thread Greg Kroah-Hartman
On Sat, Feb 17, 2018 at 07:12:17AM -0800, Guenter Roeck wrote: > On 02/17/2018 05:43 AM, Greg Kroah-Hartman wrote: > > On Fri, Feb 16, 2018 at 10:52:20AM -0800, Guenter Roeck wrote: > > > On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: > > > > On Fri, Feb 16, 2018 at 07:48:50AM

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-17 Thread Guenter Roeck
On 02/17/2018 05:43 AM, Greg Kroah-Hartman wrote: On Fri, Feb 16, 2018 at 10:52:20AM -0800, Guenter Roeck wrote: On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-17 Thread Guenter Roeck
On 02/17/2018 05:43 AM, Greg Kroah-Hartman wrote: On Fri, Feb 16, 2018 at 10:52:20AM -0800, Guenter Roeck wrote: On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-17 Thread Greg Kroah-Hartman
On Fri, Feb 16, 2018 at 10:52:20AM -0800, Guenter Roeck wrote: > On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: > > On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > > > > On Thu, Feb 15, 2018 at

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-17 Thread Greg Kroah-Hartman
On Fri, Feb 16, 2018 at 10:52:20AM -0800, Guenter Roeck wrote: > On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: > > On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > > > > On Thu, Feb 15, 2018 at

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-16 Thread Greg Kroah-Hartman
On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: > On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: > > On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > > > On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > > > > 4.4-stable review

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-16 Thread Greg Kroah-Hartman
On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: > On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: > > On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > > > On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > > > > 4.4-stable review

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-16 Thread Guenter Roeck
On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: > On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: > > On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > > > On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > > > > 4.4-stable review

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-16 Thread Guenter Roeck
On Fri, Feb 16, 2018 at 10:10:44AM -0800, Brian Norris wrote: > On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: > > On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > > > On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > > > > 4.4-stable review

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-16 Thread Brian Norris
On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > > On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me > > > know. > >

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-16 Thread Brian Norris
On Fri, Feb 16, 2018 at 07:48:50AM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > > On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me > > > know. > >

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-15 Thread Greg Kroah-Hartman
On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > Consider this an objection: > > I'm currently arguing that this is unnecessarily

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-15 Thread Greg Kroah-Hartman
On Thu, Feb 15, 2018 at 06:31:48PM -0800, Brian Norris wrote: > On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > Consider this an objection: > > I'm currently arguing that this is unnecessarily

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-15 Thread Brian Norris
On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. Consider this an objection: I'm currently arguing that this is unnecessarily regressing power consumption here:

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-15 Thread Brian Norris
On Thu, Feb 15, 2018 at 04:17:32PM +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. Consider this an objection: I'm currently arguing that this is unnecessarily regressing power consumption here:

[PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-15 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Hans de Goede commit 61f5acea8737d9b717fcc22bb6679924f3c82b98 upstream. Commit 7d06d5895c15 ("Revert "Bluetooth: btusb: fix QCA...suspend/resume"") removed the setting of

[PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-15 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Hans de Goede commit 61f5acea8737d9b717fcc22bb6679924f3c82b98 upstream. Commit 7d06d5895c15 ("Revert "Bluetooth: btusb: fix QCA...suspend/resume"") removed the setting of the