Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Jiri Kosina
On Thu, 25 Aug 2016, Jens Axboe wrote: > Which patch is this? If that is truly the case, it should be reverted > asap. I've been looking into this for the past few days, and unfortunately I am not able to come up with a simple fix, so revert seems like the way to go. Unfortunately, by

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Jiri Kosina
On Thu, 25 Aug 2016, Jens Axboe wrote: > Which patch is this? If that is truly the case, it should be reverted > asap. I've been looking into this for the past few days, and unfortunately I am not able to come up with a simple fix, so revert seems like the way to go. Unfortunately, by

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Jens Axboe
On 08/25/2016 08:53 AM, Jiri Kosina wrote: On Thu, 25 Aug 2016, Jens Axboe wrote: Which patch is this? If that is truly the case, it should be reverted asap. I've been looking into this for the past few days, and unfortunately I am not able to come up with a simple fix, so revert seems like

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Jens Axboe
On 08/25/2016 08:53 AM, Jiri Kosina wrote: On Thu, 25 Aug 2016, Jens Axboe wrote: Which patch is this? If that is truly the case, it should be reverted asap. I've been looking into this for the past few days, and unfortunately I am not able to come up with a simple fix, so revert seems like

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Mark Hounschell
On 08/25/2016 10:41 AM, Jens Axboe wrote: On 08/25/2016 07:08 AM, Mark Hounschell wrote: On 08/24/2016 05:11 PM, Jiri Kosina wrote: On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: I have a problem with this patch. It only fixes one of the regressions caused by the original change to the

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Mark Hounschell
On 08/25/2016 10:41 AM, Jens Axboe wrote: On 08/25/2016 07:08 AM, Mark Hounschell wrote: On 08/24/2016 05:11 PM, Jiri Kosina wrote: On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: I have a problem with this patch. It only fixes one of the regressions caused by the original change to the

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Jens Axboe
On 08/25/2016 07:08 AM, Mark Hounschell wrote: On 08/24/2016 05:11 PM, Jiri Kosina wrote: On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: I have a problem with this patch. It only fixes one of the regressions caused by the original change to the floppy driver. It does not address the user land

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Jens Axboe
On 08/25/2016 07:08 AM, Mark Hounschell wrote: On 08/24/2016 05:11 PM, Jiri Kosina wrote: On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: I have a problem with this patch. It only fixes one of the regressions caused by the original change to the floppy driver. It does not address the user land

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Mark Hounschell
On 08/24/2016 05:11 PM, Jiri Kosina wrote: On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: I have a problem with this patch. It only fixes one of the regressions caused by the original change to the floppy driver. It does not address the user land breakage of removing the NODELAY flag checks.

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-25 Thread Mark Hounschell
On 08/24/2016 05:11 PM, Jiri Kosina wrote: On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: I have a problem with this patch. It only fixes one of the regressions caused by the original change to the floppy driver. It does not address the user land breakage of removing the NODELAY flag checks.

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-24 Thread Jiri Kosina
On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: > > I have a problem with this patch. It only fixes one of the regressions > > caused by the original change to the floppy driver. It does not address the > > user land breakage of removing the NODELAY flag checks. > > Does the same problem also

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-24 Thread Jiri Kosina
On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: > > I have a problem with this patch. It only fixes one of the regressions > > caused by the original change to the floppy driver. It does not address the > > user land breakage of removing the NODELAY flag checks. > > Does the same problem also

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-24 Thread Greg Kroah-Hartman
On Wed, Aug 24, 2016 at 09:34:44AM -0400, Mark Hounschell wrote: > On 08/18/2016 09:59 AM, Greg Kroah-Hartman wrote: > > 4.7-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Jiri Kosina > > > > commit

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-24 Thread Greg Kroah-Hartman
On Wed, Aug 24, 2016 at 09:34:44AM -0400, Mark Hounschell wrote: > On 08/18/2016 09:59 AM, Greg Kroah-Hartman wrote: > > 4.7-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Jiri Kosina > > > > commit

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-24 Thread Mark Hounschell
On 08/18/2016 09:59 AM, Greg Kroah-Hartman wrote: 4.7-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Kosina commit ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e upstream. Commit 09954bad4 ("floppy: refactor open() flags

Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-24 Thread Mark Hounschell
On 08/18/2016 09:59 AM, Greg Kroah-Hartman wrote: 4.7-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Kosina commit ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e upstream. Commit 09954bad4 ("floppy: refactor open() flags handling"), as a

[PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-18 Thread Greg Kroah-Hartman
4.7-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Kosina commit ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e upstream. Commit 09954bad4 ("floppy: refactor open() flags handling"), as a side-effect, causes open(/dev/fdX,

[PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

2016-08-18 Thread Greg Kroah-Hartman
4.7-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Kosina commit ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e upstream. Commit 09954bad4 ("floppy: refactor open() flags handling"), as a side-effect, causes open(/dev/fdX, O_ACCMODE) to fail.