Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Thu, Nov 16, 2017 at 03:24:46PM -0800, Josh Hunt wrote: > On Thu, Nov 16, 2017 at 3:13 PM, wrote: > > > > It's possible, but I didn't want to add a bunch of clutter to the > > commit message. Right now it's somewhat easy to track it back to > > automatic selection

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Thu, Nov 16, 2017 at 03:24:46PM -0800, Josh Hunt wrote: > On Thu, Nov 16, 2017 at 3:13 PM, wrote: > > > > It's possible, but I didn't want to add a bunch of clutter to the > > commit message. Right now it's somewhat easy to track it back to > > automatic selection because: > > > > 1. I'm

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Thu, Nov 16, 2017 at 3:13 PM, wrote: > > It's possible, but I didn't want to add a bunch of clutter to the > commit message. Right now it's somewhat easy to track it back to > automatic selection because: > > 1. I'm signed off on all of them, so I could chime in

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Thu, Nov 16, 2017 at 3:13 PM, wrote: > > It's possible, but I didn't want to add a bunch of clutter to the > commit message. Right now it's somewhat easy to track it back to > automatic selection because: > > 1. I'm signed off on all of them, so I could chime in in the case > concerns/issues

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Wed, Nov 15, 2017 at 09:43:41AM -0800, Josh Hunt wrote: >I just started noticing the AUTOSEL tags yesterday and I think that's >a great idea to tag patches, but was there any thought to also putting >something in the commit message this way they're easily identifiable >in the git logs? I think

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Wed, Nov 15, 2017 at 09:43:41AM -0800, Josh Hunt wrote: >I just started noticing the AUTOSEL tags yesterday and I think that's >a great idea to tag patches, but was there any thought to also putting >something in the commit message this way they're easily identifiable >in the git logs? I think

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Tue, Oct 10, 2017 at 10:31 AM, Julia Lawall wrote: > > > On Tue, 10 Oct 2017, Levin, Alexander (Sasha Levin) wrote: > >> (Cc'ed Julia) >> >> On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote: >> >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: >>

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Tue, Oct 10, 2017 at 10:31 AM, Julia Lawall wrote: > > > On Tue, 10 Oct 2017, Levin, Alexander (Sasha Levin) wrote: > >> (Cc'ed Julia) >> >> On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote: >> >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: >> >> We are

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Tue, 10 Oct 2017, Levin, Alexander (Sasha Levin) wrote: > (Cc'ed Julia) > > On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote: > >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: > >> We are experimenting with using neural network to aid with patch > >> selection for

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Tue, 10 Oct 2017, Levin, Alexander (Sasha Levin) wrote: > (Cc'ed Julia) > > On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote: > >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: > >> We are experimenting with using neural network to aid with patch > >> selection for

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

(Cc'ed Julia) On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote: >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: >> We are experimenting with using neural network to aid with patch >> selection for stable kernel trees. There are quite a few commits that >> were not

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

(Cc'ed Julia) On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote: >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: >> We are experimenting with using neural network to aid with patch >> selection for stable kernel trees. There are quite a few commits that >> were not

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 05:30:03PM +0100, Mark Brown wrote: >On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > >> Okay, so something like [REVIEW automatic-patch-selection for 4.X] >> is sort of what you're suggesting? > >Yeah (perhaps a bit less verbose so some of

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 05:30:03PM +0100, Mark Brown wrote: >On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > >> Okay, so something like [REVIEW automatic-patch-selection for 4.X] >> is sort of what you're suggesting? > >Yeah (perhaps a bit less verbose so some of

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: > On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: >> Hi Greg, >> >> On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: >>> 4.9-stable review patch. If anyone has any objections, please let me know. >> >>

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: > On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: >> Hi Greg, >> >> On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: >>> 4.9-stable review patch. If anyone has any objections, please let me know. >> >>

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > Okay, so something like [REVIEW automatic-patch-selection for 4.X] > is sort of what you're suggesting? Yeah (perhaps a bit less verbose so some of the actual patch subject is visible!) but something visible like

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > Okay, so something like [REVIEW automatic-patch-selection for 4.X] > is sort of what you're suggesting? Yeah (perhaps a bit less verbose so some of the actual patch subject is visible!) but something visible like

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > On Mon, Oct 09, 2017 at 04:47:46PM +0100, Mark Brown wrote: > >On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) > >wrote: > > > >> In this case, for example, this patch had a "review cycle"

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > On Mon, Oct 09, 2017 at 04:47:46PM +0100, Mark Brown wrote: > >On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) > >wrote: > > > >> In this case, for example, this patch had a "review cycle"

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 04:47:46PM +0100, Mark Brown wrote: >On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) wrote: > >> In this case, for example, this patch had a "review cycle" of 18 days >> where 4 different emails regarding this patch were sent out as it was >> making

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 04:47:46PM +0100, Mark Brown wrote: >On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) wrote: > >> In this case, for example, this patch had a "review cycle" of 18 days >> where 4 different emails regarding this patch were sent out as it was >> making

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) wrote: > In this case, for example, this patch had a "review cycle" of 18 days > where 4 different emails regarding this patch were sent out as it was > making it's way through review and queues, so we already try to be > as

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) wrote: > In this case, for example, this patch had a "review cycle" of 18 days > where 4 different emails regarding this patch were sent out as it was > making it's way through review and queues, so we already try to be > as

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 01:42:26PM +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 09, 2017 at 11:06:53AM +0100, Will Deacon wrote: > > On the flip side, it means that the default response (silence) stops the > > patches getting into stable, which isn't ideal for Greg. Thoughts? > Yeah, default

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 01:42:26PM +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 09, 2017 at 11:06:53AM +0100, Will Deacon wrote: > > On the flip side, it means that the default response (silence) stops the > > patches getting into stable, which isn't ideal for Greg. Thoughts? > Yeah, default

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 01:42:26PM +0200, Greg Kroah-Hartman wrote: >On Mon, Oct 09, 2017 at 11:06:53AM +0100, Will Deacon wrote: >> On Mon, Oct 09, 2017 at 10:14:50AM +0100, Mark Brown wrote: >> > On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) >> > wrote: >> > >> > > We

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 01:42:26PM +0200, Greg Kroah-Hartman wrote: >On Mon, Oct 09, 2017 at 11:06:53AM +0100, Will Deacon wrote: >> On Mon, Oct 09, 2017 at 10:14:50AM +0100, Mark Brown wrote: >> > On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) >> > wrote: >> > >> > > We

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 11:06:53AM +0100, Will Deacon wrote: > On Mon, Oct 09, 2017 at 10:14:50AM +0100, Mark Brown wrote: > > On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) > > wrote: > > > > > We are experimenting with using neural network to aid with patch > > >

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 11:06:53AM +0100, Will Deacon wrote: > On Mon, Oct 09, 2017 at 10:14:50AM +0100, Mark Brown wrote: > > On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) > > wrote: > > > > > We are experimenting with using neural network to aid with patch > > >

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 10:14:50AM +0100, Mark Brown wrote: > On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) > wrote: > > > We are experimenting with using neural network to aid with patch > > selection for stable kernel trees. There are quite a few commits that > >

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Mon, Oct 09, 2017 at 10:14:50AM +0100, Mark Brown wrote: > On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) > wrote: > > > We are experimenting with using neural network to aid with patch > > selection for stable kernel trees. There are quite a few commits that > >

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) wrote: > We are experimenting with using neural network to aid with patch > selection for stable kernel trees. There are quite a few commits that > were not marked for stable, but are stable material, and we're trying > to

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) wrote: > We are experimenting with using neural network to aid with patch > selection for stable kernel trees. There are quite a few commits that > were not marked for stable, but are stable material, and we're trying > to

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) wrote: > On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: > >Hi Greg, > > > >On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: > >> 4.9-stable review patch. If anyone has any objections, please

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) wrote: > On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: > >Hi Greg, > > > >On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: > >> 4.9-stable review patch. If anyone has any objections, please

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: > Hi Greg, > > On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: > > 4.9-stable review patch. If anyone has any objections, please let me know. > > I'm a little confused as to why this is being backported, given it

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: > Hi Greg, > > On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: > > 4.9-stable review patch. If anyone has any objections, please let me know. > > I'm a little confused as to why this is being backported, given it

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: >Hi Greg, > >On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: >> 4.9-stable review patch. If anyone has any objections, please let me know. > >I'm a little confused as to why this is being backported, given it

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: >Hi Greg, > >On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: >> 4.9-stable review patch. If anyone has any objections, please let me know. > >I'm a little confused as to why this is being backported, given it

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

Hi Greg, On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: > 4.9-stable review patch. If anyone has any objections, please let me know. I'm a little confused as to why this is being backported, given it wasn't Cc'd stable or marked as a fix. The lm_alias() helper was only

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

Hi Greg, On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: > 4.9-stable review patch. If anyone has any objections, please let me know. I'm a little confused as to why this is being backported, given it wasn't Cc'd stable or marked as a fix. The lm_alias() helper was only

[PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Mark Rutland [ Upstream commit b0de0ccc8b9edd8846828e0ecdc35deacdf186b0 ] Booting a v4.11-rc1 kernel with DEBUG_VIRTUAL and KASAN enabled produces the following splat

[PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Mark Rutland [ Upstream commit b0de0ccc8b9edd8846828e0ecdc35deacdf186b0 ] Booting a v4.11-rc1 kernel with DEBUG_VIRTUAL and KASAN enabled produces the following splat (trimmed for brevity):