Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-30 Thread Dan Carpenter
On Tue, Apr 29, 2014 at 11:21:48PM -0400, Oleg Drokin wrote: > I can rediff this patch with this particular part dropped if there are > any concerns and it's possible to reintegrate it in a changed form. No no. I knew that Greg had already merged this stuff by the time I got around to reviewing

Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-30 Thread Dan Carpenter
On Tue, Apr 29, 2014 at 11:21:48PM -0400, Oleg Drokin wrote: I can rediff this patch with this particular part dropped if there are any concerns and it's possible to reintegrate it in a changed form. No no. I knew that Greg had already merged this stuff by the time I got around to reviewing

Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-29 Thread Oleg Drokin
Hello! On Apr 29, 2014, at 7:02 AM, Dan Carpenter wrote: >> diff --git a/drivers/staging/lustre/lustre/llite/statahead.c >> b/drivers/staging/lustre/lustre/llite/statahead.c >> index 51c5327..1b47774 100644 >> --- a/drivers/staging/lustre/lustre/llite/statahead.c >> +++

Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-29 Thread Dan Carpenter
kernel@vger.kernel.org; > > de...@driverdev.osuosl.org; Drokin, Oleg; Hammond, John > > Subject: Re: [PATCH 41/47] staging/lustre/llite: remove dead code > > > > On Sun, Apr 27, 2014 at 01:07:05PM -0400, Oleg Drokin wrote: > > > From: "John L. Hammond" > > > > &

RE: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-29 Thread Hammond, John
[PATCH 41/47] staging/lustre/llite: remove dead code > > On Sun, Apr 27, 2014 at 01:07:05PM -0400, Oleg Drokin wrote: > > From: "John L. Hammond" > > > > In llite remove unused declarations, parameters, types, and unused, > > get-only, or set-only structure membe

Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-29 Thread Dan Carpenter
On Sun, Apr 27, 2014 at 01:07:05PM -0400, Oleg Drokin wrote: > From: "John L. Hammond" > > In llite remove unused declarations, parameters, types, and unused, > get-only, or set-only structure members. Add static and const > qualifiers to declarations where possible. > > Signed-off-by: John L.

Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-29 Thread Dan Carpenter
On Sun, Apr 27, 2014 at 01:07:05PM -0400, Oleg Drokin wrote: From: John L. Hammond john.hamm...@intel.com In llite remove unused declarations, parameters, types, and unused, get-only, or set-only structure members. Add static and const qualifiers to declarations where possible.

RE: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-29 Thread Hammond, John
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Tuesday, April 29, 2014 6:03 AM To: Oleg Drokin Cc: Greg Kroah-Hartman; linux-kernel@vger.kernel.org; de...@driverdev.osuosl.org; Drokin, Oleg; Hammond, John Subject: Re: [PATCH 41/47] staging/lustre

Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-29 Thread Dan Carpenter
, Oleg; Hammond, John Subject: Re: [PATCH 41/47] staging/lustre/llite: remove dead code On Sun, Apr 27, 2014 at 01:07:05PM -0400, Oleg Drokin wrote: From: John L. Hammond john.hamm...@intel.com In llite remove unused declarations, parameters, types, and unused, get-only, or set

Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-29 Thread Oleg Drokin
Hello! On Apr 29, 2014, at 7:02 AM, Dan Carpenter wrote: diff --git a/drivers/staging/lustre/lustre/llite/statahead.c b/drivers/staging/lustre/lustre/llite/statahead.c index 51c5327..1b47774 100644 --- a/drivers/staging/lustre/lustre/llite/statahead.c +++

[PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-27 Thread Oleg Drokin
From: "John L. Hammond" In llite remove unused declarations, parameters, types, and unused, get-only, or set-only structure members. Add static and const qualifiers to declarations where possible. Signed-off-by: John L. Hammond Reviewed-on: http://review.whamcloud.com/9767 Intel-bug-id:

[PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-27 Thread Oleg Drokin
From: John L. Hammond john.hamm...@intel.com In llite remove unused declarations, parameters, types, and unused, get-only, or set-only structure members. Add static and const qualifiers to declarations where possible. Signed-off-by: John L. Hammond john.hamm...@intel.com Reviewed-on: