Re: [PATCH 44/47] Minor fixes for CRISv32 io.h

2007-12-12 Thread Jesper Nilsson
On Wed, Dec 12, 2007 at 03:29:39AM -0800, Andrew Morton wrote: > On Mon, 3 Dec 2007 11:16:25 +0100 Jesper Nilsson <[EMAIL PROTECTED]> wrote: > > struct crisv32_ioport > > { > > - unsigned long* oe; > > - unsigned long* data; > > - unsigned long* data_in; > > + volatile unsigned long *oe; > >

Re: [PATCH 44/47] Minor fixes for CRISv32 io.h

2007-12-12 Thread Andrew Morton
On Mon, 3 Dec 2007 11:16:25 +0100 Jesper Nilsson <[EMAIL PROTECTED]> wrote: > - Shorten include paths for machine dependent header files. > - Add volatile to hardeware register pointers. > - Add spinlocks around critical region. > - Expand macros for handling of leds. > > ... > > struct

Re: [PATCH 44/47] Minor fixes for CRISv32 io.h

2007-12-12 Thread Andrew Morton
On Mon, 3 Dec 2007 11:16:25 +0100 Jesper Nilsson [EMAIL PROTECTED] wrote: - Shorten include paths for machine dependent header files. - Add volatile to hardeware register pointers. - Add spinlocks around critical region. - Expand macros for handling of leds. ... struct crisv32_ioport

Re: [PATCH 44/47] Minor fixes for CRISv32 io.h

2007-12-12 Thread Jesper Nilsson
On Wed, Dec 12, 2007 at 03:29:39AM -0800, Andrew Morton wrote: On Mon, 3 Dec 2007 11:16:25 +0100 Jesper Nilsson [EMAIL PROTECTED] wrote: struct crisv32_ioport { - unsigned long* oe; - unsigned long* data; - unsigned long* data_in; + volatile unsigned long *oe; + volatile

[PATCH 44/47] Minor fixes for CRISv32 io.h

2007-12-06 Thread Jesper Nilsson
- Shorten include paths for machine dependent header files. - Add volatile to hardeware register pointers. - Add spinlocks around critical region. - Expand macros for handling of leds. Signed-off-by: Jesper Nilsson <[EMAIL PROTECTED]> --- include/asm-cris/arch-v32/io.h | 70

[PATCH 44/47] Minor fixes for CRISv32 io.h

2007-12-06 Thread Jesper Nilsson
- Shorten include paths for machine dependent header files. - Add volatile to hardeware register pointers. - Add spinlocks around critical region. - Expand macros for handling of leds. Signed-off-by: Jesper Nilsson [EMAIL PROTECTED] --- include/asm-cris/arch-v32/io.h | 70