Re: [PATCH 47/61] perf c2c report: Add cacheline browser

2016-09-21 Thread Kim Phillips
On Wed, 21 Sep 2016 14:55:40 +0200 Jiri Olsa wrote: > On Wed, Sep 21, 2016 at 10:21:55AM +0200, Jiri Olsa wrote: > > On Tue, Sep 20, 2016 at 03:10:07PM -0500, Kim Phillips wrote: > > > this fails to build on systems without slang: > > > > > > CC builtin-c2c.o > > > builtin-c2c.c: In func

Re: [PATCH 47/61] perf c2c report: Add cacheline browser

2016-09-21 Thread Jiri Olsa
On Wed, Sep 21, 2016 at 10:21:55AM +0200, Jiri Olsa wrote: > On Tue, Sep 20, 2016 at 03:10:07PM -0500, Kim Phillips wrote: > > On Mon, 19 Sep 2016 15:09:56 +0200 > > Jiri Olsa wrote: > > > > > + /* reset abort key so that it can get Ctrl-C as a key */ > > > + SLang_reset_tty(); > > > + SLang_init

Re: [PATCH 47/61] perf c2c report: Add cacheline browser

2016-09-21 Thread Jiri Olsa
On Tue, Sep 20, 2016 at 03:10:07PM -0500, Kim Phillips wrote: > On Mon, 19 Sep 2016 15:09:56 +0200 > Jiri Olsa wrote: > > > + /* reset abort key so that it can get Ctrl-C as a key */ > > + SLang_reset_tty(); > > + SLang_init_tty(0, 0, 0); > > this fails to build on systems without slang: >

Re: [PATCH 47/61] perf c2c report: Add cacheline browser

2016-09-20 Thread Kim Phillips
On Mon, 19 Sep 2016 15:09:56 +0200 Jiri Olsa wrote: > + /* reset abort key so that it can get Ctrl-C as a key */ > + SLang_reset_tty(); > + SLang_init_tty(0, 0, 0); this fails to build on systems without slang: CC builtin-c2c.o builtin-c2c.c: In function ‘perf_c2c__browse_ca

[PATCH 47/61] perf c2c report: Add cacheline browser

2016-09-19 Thread Jiri Olsa
Adding single cacheline TUI browser. It triggers when you press 'd' in the main browser on the specific cacheline. It allows to navigate through cacheline's offsets and display callchains (implemented in following patches). Link: http://lkml.kernel.org/n/tip-fovjwgyusv3rz5qxk3hna...@git.kernel.or