Re: [PATCH 5/11 RFC] PCI: pciehp: Make "Power On" the default

2020-07-10 Thread Saheed Bolarinwa
On 7/10/20 2:14 AM, Bjorn Helgaas wrote: On Mon, Jul 06, 2020 at 11:31:15AM +0200, Saheed Olayemi Bolarinwa wrote: From: Bolarinwa Olayemi Saheed The default case of the switch statement is redundant since PCI_EXP_SLTCTL_PCC is only a single bit. pcie_capability_read_word() currently causes

Re: [PATCH 5/11 RFC] PCI: pciehp: Make "Power On" the default

2020-07-09 Thread Bjorn Helgaas
On Mon, Jul 06, 2020 at 11:31:15AM +0200, Saheed Olayemi Bolarinwa wrote: > From: Bolarinwa Olayemi Saheed > > The default case of the switch statement is redundant since > PCI_EXP_SLTCTL_PCC is only a single bit. pcie_capability_read_word() > currently causes "On" value to be set if it fails.

[PATCH 5/11 RFC] PCI: pciehp: Make "Power On" the default

2020-07-06 Thread Saheed Olayemi Bolarinwa
From: Bolarinwa Olayemi Saheed The default case of the switch statement is redundant since PCI_EXP_SLTCTL_PCC is only a single bit. pcie_capability_read_word() currently causes "On" value to be set if it fails. Patch 11/11 changes the behaviour of pcie_capability_read_word() so on falure the