On Sun, Sep 14, 2014 at 10:27:43AM +0800, Jianqun wrote:
> 在 09/14/2014 12:37 AM, Mark Brown 写道:
> >> + ret = clk_prepare_enable(i2s->hclk);
> >> + if (ret) {
> >> + dev_err(i2s->dev, "hclock enable failed %d\n", ret);
> >> + return ret;
> >> + }
> > BTW: you're also missing
On Sun, Sep 14, 2014 at 10:27:43AM +0800, Jianqun wrote:
在 09/14/2014 12:37 AM, Mark Brown 写道:
+ ret = clk_prepare_enable(i2s-hclk);
+ if (ret) {
+ dev_err(i2s-dev, hclock enable failed %d\n, ret);
+ return ret;
+ }
BTW: you're also missing a
在 09/14/2014 12:37 AM, Mark Brown 写道:
> On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
>
>> +++ b/sound/soc/rockchip/rockchip_i2s.c
>> @@ -423,6 +423,11 @@ static int rockchip_i2s_probe(struct platform_device
>> *pdev)
>> dev_err(>dev, "Can't retrieve i2s bus clock\n");
在 09/14/2014 12:36 AM, Mark Brown 写道:
> On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
>> As "hclk" is used for rockchip I2S controller, driver must to enable
>> it in probe.
>
> Applied, again this is a bug fix. How did the original submission get
> tested?
>
The original
On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
> +++ b/sound/soc/rockchip/rockchip_i2s.c
> @@ -423,6 +423,11 @@ static int rockchip_i2s_probe(struct platform_device
> *pdev)
> dev_err(>dev, "Can't retrieve i2s bus clock\n");
> return PTR_ERR(i2s->hclk);
>
On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
> As "hclk" is used for rockchip I2S controller, driver must to enable
> it in probe.
Applied, again this is a bug fix. How did the original submission get
tested?
signature.asc
Description: Digital signature
On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
As hclk is used for rockchip I2S controller, driver must to enable
it in probe.
Applied, again this is a bug fix. How did the original submission get
tested?
signature.asc
Description: Digital signature
On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -423,6 +423,11 @@ static int rockchip_i2s_probe(struct platform_device
*pdev)
dev_err(pdev-dev, Can't retrieve i2s bus clock\n);
return PTR_ERR(i2s-hclk);
}
在 09/14/2014 12:36 AM, Mark Brown 写道:
On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
As hclk is used for rockchip I2S controller, driver must to enable
it in probe.
Applied, again this is a bug fix. How did the original submission get
tested?
The original submission is
在 09/14/2014 12:37 AM, Mark Brown 写道:
On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote:
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -423,6 +423,11 @@ static int rockchip_i2s_probe(struct platform_device
*pdev)
dev_err(pdev-dev, Can't retrieve i2s bus clock\n);
As "hclk" is used for rockchip I2S controller, driver must to enable
it in probe.
Tested on RK3288 with max98090.
Signed-off-by: Jianqun Xu
---
sound/soc/rockchip/rockchip_i2s.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/sound/soc/rockchip/rockchip_i2s.c
As hclk is used for rockchip I2S controller, driver must to enable
it in probe.
Tested on RK3288 with max98090.
Signed-off-by: Jianqun Xu jay...@rock-chips.com
---
sound/soc/rockchip/rockchip_i2s.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/sound/soc/rockchip/rockchip_i2s.c
12 matches
Mail list logo
