On Mon, 2016-09-26 at 14:52 +0200, SF Markus Elfring wrote:
> Would it eventually make sense to move this "if" (behind an "else")
> to a separate line and increase the indentation for the corresponding
> code one level then?
No.
Paul Bolle
@@ -976,13 +974,12 @@ static void handle_controller(_cmsg *cmsg)
if (debugmode)
printk(KERN_DEBUG "capidrv-%d: listenconf Info=0x%4x
(%s) cipmask=0x%x\n",
card->contrnr, cmsg->Info,
capi_info2str(cmsg->Info), card->cipmask);
>>
On Sun, 2016-09-25 at 14:47 +0200, SF Markus Elfring wrote:
> > > @@ -976,13 +974,12 @@ static void handle_controller(_cmsg *cmsg)
> > > if (debugmode)
> > > printk(KERN_DEBUG "capidrv-%d: listenconf Info=0x%4x
> > > (%s) cipmask=0x%x\n",
> > > card->contrn
>> @@ -976,13 +974,12 @@ static void handle_controller(_cmsg *cmsg)
>> if (debugmode)
>> printk(KERN_DEBUG "capidrv-%d: listenconf Info=0x%4x (%s)
>> cipmask=0x%x\n",
>> card->contrnr, cmsg->Info, capi_info2str(cmsg->Info),
>> card->cipmask);
>> -
Hello.
On 9/25/2016 2:15 PM, SF Markus Elfring wrote:
From: Markus Elfring
Date: Sun, 25 Sep 2016 12:50:21 +0200
Do not use curly brackets at eight source code places
where a single statement should be sufficient.
Signed-off-by: Markus Elfring
---
drivers/isdn/capi/capidrv.c | 30 +
From: Markus Elfring
Date: Sun, 25 Sep 2016 12:50:21 +0200
Do not use curly brackets at eight source code places
where a single statement should be sufficient.
Signed-off-by: Markus Elfring
---
drivers/isdn/capi/capidrv.c | 30 +++---
1 file changed, 11 insertions(+), 1
6 matches
Mail list logo
