Re: [PATCH 5/5] Input: omap4-keypad - implement errata check for lost key-up events

2021-01-11 Thread Tony Lindgren
* Pavel Machek [210111 08:34]: > Hi! > > > We are still missing handling for errata i689 related issues for the > > case where we never see a key up interrupt for the last pressed key. > > > > To fix the issue, we must scan the key state again after the keyboard > > controller has idled to check

Re: [PATCH 5/5] Input: omap4-keypad - implement errata check for lost key-up events

2021-01-11 Thread Pavel Machek
Hi! > We are still missing handling for errata i689 related issues for the > case where we never see a key up interrupt for the last pressed key. > > To fix the issue, we must scan the key state again after the keyboard > controller has idled to check if a key up event was missed. This is > descr

Re: [PATCH 5/5] Input: omap4-keypad - implement errata check for lost key-up events

2021-01-10 Thread Dmitry Torokhov
On Mon, Jan 11, 2021 at 08:10:18AM +0200, Tony Lindgren wrote: > * Tony Lindgren [210110 19:08]: > > --- a/drivers/input/keyboard/omap4-keypad.c > > +++ b/drivers/input/keyboard/omap4-keypad.c > > +/* > > + * Errata ID i689 "1.32 Keyboard Key Up Event Can Be Missed". > > + * Interrupt may not happ

Re: [PATCH 5/5] Input: omap4-keypad - implement errata check for lost key-up events

2021-01-10 Thread Tony Lindgren
* Tony Lindgren [210110 19:08]: > --- a/drivers/input/keyboard/omap4-keypad.c > +++ b/drivers/input/keyboard/omap4-keypad.c > +/* > + * Errata ID i689 "1.32 Keyboard Key Up Event Can Be Missed". > + * Interrupt may not happen for key-up events. We must clear stuck > + * key-up events after the key

[PATCH 5/5] Input: omap4-keypad - implement errata check for lost key-up events

2021-01-10 Thread Tony Lindgren
We are still missing handling for errata i689 related issues for the case where we never see a key up interrupt for the last pressed key. To fix the issue, we must scan the key state again after the keyboard controller has idled to check if a key up event was missed. This is described in the omap4