Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-31 Thread Chris Wright
* Greg KH ([EMAIL PROTECTED]) wrote: > On Wed, Aug 24, 2005 at 06:20:33PM -0700, Chris Wright wrote: > > Now that capability functions are default, rootplug no longer needs to > > manually add them to its security_ops. > > > > Cc: Greg Kroah <[EMAIL PROTECTED]> > > Signed-off-by: Chris Wright

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-31 Thread Greg KH
On Wed, Aug 24, 2005 at 06:20:33PM -0700, Chris Wright wrote: > Now that capability functions are default, rootplug no longer needs to > manually add them to its security_ops. > > Cc: Greg Kroah <[EMAIL PROTECTED]> > Signed-off-by: Chris Wright <[EMAIL PROTECTED]> You can add: Signed-off-by:

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-31 Thread Greg KH
On Wed, Aug 24, 2005 at 06:20:33PM -0700, Chris Wright wrote: Now that capability functions are default, rootplug no longer needs to manually add them to its security_ops. Cc: Greg Kroah [EMAIL PROTECTED] Signed-off-by: Chris Wright [EMAIL PROTECTED] You can add: Signed-off-by: Greg

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-31 Thread Chris Wright
* Greg KH ([EMAIL PROTECTED]) wrote: On Wed, Aug 24, 2005 at 06:20:33PM -0700, Chris Wright wrote: Now that capability functions are default, rootplug no longer needs to manually add them to its security_ops. Cc: Greg Kroah [EMAIL PROTECTED] Signed-off-by: Chris Wright [EMAIL

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Chris Wright
* [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote: > @@ -1527,7 +1533,8 @@ static int selinux_vm_enough_memory(long > int rc, cap_sys_admin = 0; > struct task_security_struct *tsec = current->security; > > - rc = secondary_ops->capable(current, CAP_SYS_ADMIN); > + rc =

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Chris Wright
* Chris Wright ([EMAIL PROTECTED]) wrote: > * Stephen Smalley ([EMAIL PROTECTED]) wrote: > > e.g. if secondary_ops->capable is null, the SELinux tests aren't going > > to show that, because they will still see that the SELinux permission > > checks are working correctly. They only test

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Chris Wright
* Stephen Smalley ([EMAIL PROTECTED]) wrote: > On Thu, 2005-08-25 at 09:21 -0700, Chris Wright wrote: > > * Stephen Smalley ([EMAIL PROTECTED]) wrote: > > > On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: > > > > Ok, with the attached patch SELinux seems to work correctly. You'll > >

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread serue
Quoting Chris Wright ([EMAIL PROTECTED]): > * Stephen Smalley ([EMAIL PROTECTED]) wrote: > > On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: > > > Ok, with the attached patch SELinux seems to work correctly. You'll > > > probably want to make it a little prettier :) Note I have NOT

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Stephen Smalley
On Thu, 2005-08-25 at 09:21 -0700, Chris Wright wrote: > * Stephen Smalley ([EMAIL PROTECTED]) wrote: > > On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: > > > Ok, with the attached patch SELinux seems to work correctly. You'll > > > probably want to make it a little prettier :)

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Chris Wright
* Stephen Smalley ([EMAIL PROTECTED]) wrote: > On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: > > Ok, with the attached patch SELinux seems to work correctly. You'll > > probably want to make it a little prettier :) Note I have NOT ran the > > ltp tests for correctness. I'll do

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Stephen Smalley
On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: > Ok, with the attached patch SELinux seems to work correctly. You'll > probably want to make it a little prettier :) Note I have NOT ran the > ltp tests for correctness. I'll do some performance runs, though > unfortunately can't do

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread serue
Ok, with the attached patch SELinux seems to work correctly. You'll probably want to make it a little prettier :) Note I have NOT ran the ltp tests for correctness. I'll do some performance runs, though unfortunately can't do so on ppc right now. thanks, -serge Signed-off-by: Serge Hallyn

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread serue
Ok, with the attached patch SELinux seems to work correctly. You'll probably want to make it a little prettier :) Note I have NOT ran the ltp tests for correctness. I'll do some performance runs, though unfortunately can't do so on ppc right now. thanks, -serge Signed-off-by: Serge Hallyn

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Stephen Smalley
On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: Ok, with the attached patch SELinux seems to work correctly. You'll probably want to make it a little prettier :) Note I have NOT ran the ltp tests for correctness. I'll do some performance runs, though unfortunately can't do so

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Chris Wright
* Stephen Smalley ([EMAIL PROTECTED]) wrote: On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: Ok, with the attached patch SELinux seems to work correctly. You'll probably want to make it a little prettier :) Note I have NOT ran the ltp tests for correctness. I'll do some

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Stephen Smalley
On Thu, 2005-08-25 at 09:21 -0700, Chris Wright wrote: * Stephen Smalley ([EMAIL PROTECTED]) wrote: On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: Ok, with the attached patch SELinux seems to work correctly. You'll probably want to make it a little prettier :) Note I have

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread serue
Quoting Chris Wright ([EMAIL PROTECTED]): * Stephen Smalley ([EMAIL PROTECTED]) wrote: On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: Ok, with the attached patch SELinux seems to work correctly. You'll probably want to make it a little prettier :) Note I have NOT ran the

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Chris Wright
* Stephen Smalley ([EMAIL PROTECTED]) wrote: On Thu, 2005-08-25 at 09:21 -0700, Chris Wright wrote: * Stephen Smalley ([EMAIL PROTECTED]) wrote: On Thu, 2005-08-25 at 09:38 -0500, [EMAIL PROTECTED] wrote: Ok, with the attached patch SELinux seems to work correctly. You'll probably

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Chris Wright
* Chris Wright ([EMAIL PROTECTED]) wrote: * Stephen Smalley ([EMAIL PROTECTED]) wrote: e.g. if secondary_ops-capable is null, the SELinux tests aren't going to show that, because they will still see that the SELinux permission checks are working correctly. They only test failure/success

Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-25 Thread Chris Wright
* [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote: @@ -1527,7 +1533,8 @@ static int selinux_vm_enough_memory(long int rc, cap_sys_admin = 0; struct task_security_struct *tsec = current-security; - rc = secondary_ops-capable(current, CAP_SYS_ADMIN); + rc =

[PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-24 Thread Chris Wright
Now that capability functions are default, rootplug no longer needs to manually add them to its security_ops. Cc: Greg Kroah <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTECTED]> --- security/root_plug.c | 14 +- 1 files changed, 1 insertion(+), 13 deletions(-)

[PATCH 5/5] Remove unnecesary capability hooks in rootplug.

2005-08-24 Thread Chris Wright
Now that capability functions are default, rootplug no longer needs to manually add them to its security_ops. Cc: Greg Kroah [EMAIL PROTECTED] Signed-off-by: Chris Wright [EMAIL PROTECTED] --- security/root_plug.c | 14 +- 1 files changed, 1 insertion(+), 13 deletions(-) Index: