Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-08 Thread Tony Lindgren
* Pantelis Antoniou [130807 09:31]: > Hi Tony, > > On Aug 7, 2013, at 7:15 PM, Tony Lindgren wrote: > > > * Pantelis Antoniou [130806 02:44]: > >> On Aug 6, 2013, at 12:33 PM, Greg Kroah-Hartman wrote: > >>> On Tue, Aug 06, 2013 at 10:53:44AM +0300, Pantelis Antoniou wrote: > + >

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-08 Thread Tony Lindgren
* Pantelis Antoniou pa...@antoniou-consulting.com [130807 09:31]: Hi Tony, On Aug 7, 2013, at 7:15 PM, Tony Lindgren wrote: * Pantelis Antoniou pa...@antoniou-consulting.com [130806 02:44]: On Aug 6, 2013, at 12:33 PM, Greg Kroah-Hartman wrote: On Tue, Aug 06, 2013 at 10:53:44AM +0300,

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-07 Thread Pantelis Antoniou
Hi Tony, On Aug 7, 2013, at 7:15 PM, Tony Lindgren wrote: > * Pantelis Antoniou [130806 02:44]: >> On Aug 6, 2013, at 12:33 PM, Greg Kroah-Hartman wrote: >>> On Tue, Aug 06, 2013 at 10:53:44AM +0300, Pantelis Antoniou wrote: + static int _omap_device_notifier_call(struct

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-07 Thread Tony Lindgren
* Pantelis Antoniou [130806 02:44]: > On Aug 6, 2013, at 12:33 PM, Greg Kroah-Hartman wrote: > > On Tue, Aug 06, 2013 at 10:53:44AM +0300, Pantelis Antoniou wrote: > >> + > >> static int _omap_device_notifier_call(struct notifier_block *nb, > >> unsigned long

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-07 Thread Alexander Holler
Am 07.08.2013 07:52, schrieb Greg Kroah-Hartman: On Tue, Aug 06, 2013 at 03:37:13PM +0200, Alexander Holler wrote: Am 06.08.2013 12:14, schrieb Greg Kroah-Hartman: What exactly is a platform device anyway? Originally it was a "something that wasn't connected to a bus, but just had

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-07 Thread Pantelis Antoniou
Hi Greg, On Aug 6, 2013, at 1:14 PM, Greg Kroah-Hartman wrote: > On Tue, Aug 06, 2013 at 12:37:25PM +0300, Pantelis Antoniou wrote: >>> I don't like this at all, sorry. >>> >> [snip] >> Don't shoot the messenger please... >> >> This is all about fixing a crash without messing too many

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-07 Thread Pantelis Antoniou
Hi Greg, On Aug 6, 2013, at 1:14 PM, Greg Kroah-Hartman wrote: On Tue, Aug 06, 2013 at 12:37:25PM +0300, Pantelis Antoniou wrote: I don't like this at all, sorry. [snip] Don't shoot the messenger please... This is all about fixing a crash without messing too many things. I

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-07 Thread Alexander Holler
Am 07.08.2013 07:52, schrieb Greg Kroah-Hartman: On Tue, Aug 06, 2013 at 03:37:13PM +0200, Alexander Holler wrote: Am 06.08.2013 12:14, schrieb Greg Kroah-Hartman: What exactly is a platform device anyway? Originally it was a something that wasn't connected to a bus, but just had

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-07 Thread Tony Lindgren
* Pantelis Antoniou pa...@antoniou-consulting.com [130806 02:44]: On Aug 6, 2013, at 12:33 PM, Greg Kroah-Hartman wrote: On Tue, Aug 06, 2013 at 10:53:44AM +0300, Pantelis Antoniou wrote: + static int _omap_device_notifier_call(struct notifier_block *nb,

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-07 Thread Pantelis Antoniou
Hi Tony, On Aug 7, 2013, at 7:15 PM, Tony Lindgren wrote: * Pantelis Antoniou pa...@antoniou-consulting.com [130806 02:44]: On Aug 6, 2013, at 12:33 PM, Greg Kroah-Hartman wrote: On Tue, Aug 06, 2013 at 10:53:44AM +0300, Pantelis Antoniou wrote: + static int

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 03:37:13PM +0200, Alexander Holler wrote: > Am 06.08.2013 12:14, schrieb Greg Kroah-Hartman: > > >> What exactly is a platform device anyway? > > > > Originally it was a "something that wasn't connected to a bus, but just > > had memory-mapped i/o." Like the PS2 keyboard

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Alexander Holler
Am 06.08.2013 12:14, schrieb Greg Kroah-Hartman: >> What exactly is a platform device anyway? > > Originally it was a "something that wasn't connected to a bus, but just > had memory-mapped i/o." Like the PS2 keyboard controller. > > Embedded systems got ahold of this and went to town, and

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 12:37:25PM +0300, Pantelis Antoniou wrote: > > I don't like this at all, sorry. > > > > Don't shoot the messenger please... > > This is all about fixing a crash without messing too many things. I understand, it's not your fault at all. > > And I was waiting for the day

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Pantelis Antoniou
Hi Greg, On Aug 6, 2013, at 12:33 PM, Greg Kroah-Hartman wrote: > On Tue, Aug 06, 2013 at 10:53:44AM +0300, Pantelis Antoniou wrote: >> Removing any omap device always resulted in a crash; turns out >> BUS_NOTIFY_DEL_DEVICE is not the last notifier event sent in the >> course of removing the

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 10:53:44AM +0300, Pantelis Antoniou wrote: > Removing any omap device always resulted in a crash; turns out > BUS_NOTIFY_DEL_DEVICE is not the last notifier event sent in the > course of removing the device, the correct event is > BUS_NOTIFY_UNBOUND_DRIVER, which still is

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 10:53:44AM +0300, Pantelis Antoniou wrote: Removing any omap device always resulted in a crash; turns out BUS_NOTIFY_DEL_DEVICE is not the last notifier event sent in the course of removing the device, the correct event is BUS_NOTIFY_UNBOUND_DRIVER, which still is not

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Pantelis Antoniou
Hi Greg, On Aug 6, 2013, at 12:33 PM, Greg Kroah-Hartman wrote: On Tue, Aug 06, 2013 at 10:53:44AM +0300, Pantelis Antoniou wrote: Removing any omap device always resulted in a crash; turns out BUS_NOTIFY_DEL_DEVICE is not the last notifier event sent in the course of removing the device,

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 12:37:25PM +0300, Pantelis Antoniou wrote: I don't like this at all, sorry. Don't shoot the messenger please... This is all about fixing a crash without messing too many things. I understand, it's not your fault at all. And I was waiting for the day when

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Alexander Holler
Am 06.08.2013 12:14, schrieb Greg Kroah-Hartman: What exactly is a platform device anyway? Originally it was a something that wasn't connected to a bus, but just had memory-mapped i/o. Like the PS2 keyboard controller. Embedded systems got ahold of this and went to town, and made

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 03:37:13PM +0200, Alexander Holler wrote: Am 06.08.2013 12:14, schrieb Greg Kroah-Hartman: What exactly is a platform device anyway? Originally it was a something that wasn't connected to a bus, but just had memory-mapped i/o. Like the PS2 keyboard controller.