Re: [PATCH 5/5] arm64: dts: qcom: sdm845-cheza: remove macro from unit name

2019-07-23 Thread Stephen Boyd
Quoting Vinod Koul (2019-07-22 05:34:22) > Unit name is supposed to be a number, using a macro with hex value is > not recommended, so add the value in unit name. > > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi:966.16-969.4: Warning > (unit_address_format):

Re: [PATCH 5/5] arm64: dts: qcom: sdm845-cheza: remove macro from unit name

2019-07-22 Thread Bjorn Andersson
On Mon 22 Jul 22:14 PDT 2019, Vinod Koul wrote: > On 23-07-19, 10:38, Amit Kucheria wrote: > > On Mon, Jul 22, 2019 at 6:06 PM Vinod Koul wrote: > > > > > > Unit name is supposed to be a number, using a macro with hex value is > > > > /s/name/address? > > Right, will fix. > > > > not

Re: [PATCH 5/5] arm64: dts: qcom: sdm845-cheza: remove macro from unit name

2019-07-22 Thread Vinod Koul
On 23-07-19, 10:38, Amit Kucheria wrote: > On Mon, Jul 22, 2019 at 6:06 PM Vinod Koul wrote: > > > > Unit name is supposed to be a number, using a macro with hex value is > > /s/name/address? Right, will fix. > > not recommended, so add the value in unit name. > > > >

Re: [PATCH 5/5] arm64: dts: qcom: sdm845-cheza: remove macro from unit name

2019-07-22 Thread Amit Kucheria
On Mon, Jul 22, 2019 at 6:06 PM Vinod Koul wrote: > > Unit name is supposed to be a number, using a macro with hex value is /s/name/address? > not recommended, so add the value in unit name. > > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi:966.16-969.4: Warning > (unit_address_format):

[PATCH 5/5] arm64: dts: qcom: sdm845-cheza: remove macro from unit name

2019-07-22 Thread Vinod Koul
Unit name is supposed to be a number, using a macro with hex value is not recommended, so add the value in unit name. arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi:966.16-969.4: Warning (unit_address_format): /soc@0/spmi@c44/pmic@0/adc@3100/adc-chan@0x4d: unit name should not have leading "0x"