Re: [PATCH 5/5] blk-mq: make plug work for mutiple disks and queues

2015-05-04 Thread Shaohua Li
(*request_count)++; > > + *same_queue_rq = rq; > > + } > > Out of the 3 callers of blk_attempt_plug_merge, only one will use the > result, yet all of them have to provide the argument. How about just > handling NULL in there? Ok, fixed. Also the updated patch fixed a bug in t

Re: [PATCH 5/5] blk-mq: make plug work for mutiple disks and queues

2015-05-01 Thread Jeff Moyer
Shaohua Li writes: > Last patch makes plug work for multiple queue case. However it only > works for single disk case, because it assumes only one request in the > plug list. If a task is accessing multiple disks, eg MD/DM, the > assumption is wrong. Let blk_attempt_plug_merge() record request fr

[PATCH 5/5] blk-mq: make plug work for mutiple disks and queues

2015-04-30 Thread Shaohua Li
Last patch makes plug work for multiple queue case. However it only works for single disk case, because it assumes only one request in the plug list. If a task is accessing multiple disks, eg MD/DM, the assumption is wrong. Let blk_attempt_plug_merge() record request from the same queue. Cc: Jens