Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-11-30 Thread Stephen Boyd
On 10/21, Julia Lawall wrote: > for_each_available_child_of_node performs an of_node_get on each iteration, > so a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local

Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-11-30 Thread Stephen Boyd
On 11/26, Sudeep Holla wrote: > Hi Mike/Stephen, > > On Thu, Oct 22, 2015 at 10:21 AM, Sudeep Holla wrote: > > > > > > Thanks for the fix. > > > > Acked-by: Sudeep Holla > > > > PS: Since this driver is queued via arm-soc, it needs to go via them or > > wait for v4.4-rc1 and then queue via clk

Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-11-30 Thread Stephen Boyd
On 11/26, Sudeep Holla wrote: > Hi Mike/Stephen, > > On Thu, Oct 22, 2015 at 10:21 AM, Sudeep Holla wrote: > > > > > > Thanks for the fix. > > > > Acked-by: Sudeep Holla > > > > PS: Since this driver is queued via arm-soc, it needs to go via them or >

Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-11-30 Thread Stephen Boyd
On 10/21, Julia Lawall wrote: > for_each_available_child_of_node performs an of_node_get on each iteration, > so a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local

Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-11-26 Thread Sudeep Holla
Hi Mike/Stephen, On Thu, Oct 22, 2015 at 10:21 AM, Sudeep Holla wrote: > > > Thanks for the fix. > > Acked-by: Sudeep Holla > > PS: Since this driver is queued via arm-soc, it needs to go via them or > wait for v4.4-rc1 and then queue via clk tree. > Now that the driver is in mainline, can you

Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-11-26 Thread Sudeep Holla
Hi Mike/Stephen, On Thu, Oct 22, 2015 at 10:21 AM, Sudeep Holla wrote: > > > Thanks for the fix. > > Acked-by: Sudeep Holla > > PS: Since this driver is queued via arm-soc, it needs to go via them or > wait for v4.4-rc1 and then queue via clk tree. >

Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-10-22 Thread Sudeep Holla
On 21/10/15 21:41, Julia Lawall wrote: for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local

Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-10-22 Thread Sudeep Holla
On 21/10/15 21:41, Julia Lawall wrote: for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local

Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-10-21 Thread Stephen Boyd
On 10/21, Julia Lawall wrote: > for_each_available_child_of_node performs an of_node_get on each iteration, > so a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local

[PATCH 5/5] clk: scpi: add missing of_node_put

2015-10-21 Thread Julia Lawall
for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@

[PATCH 5/5] clk: scpi: add missing of_node_put

2015-10-21 Thread Julia Lawall
for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@

Re: [PATCH 5/5] clk: scpi: add missing of_node_put

2015-10-21 Thread Stephen Boyd
On 10/21, Julia Lawall wrote: > for_each_available_child_of_node performs an of_node_get on each iteration, > so a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local