Re: [PATCH 5/5] drivers/usb/host/ehci-platform.c: fix error return code

2012-08-15 Thread Alan Stern
On Tue, 14 Aug 2012, Julia Lawall wrote: > From: Julia Lawall > > Convert a possibly 0 error return code to a negative one, as returned > elsewhere in the function. ... > diff --git a/drivers/usb/host/ehci-platform.c > b/drivers/usb/host/ehci-platform.c > index 91acdde..764e010 100644 > ---

Re: [PATCH 5/5] drivers/usb/host/ehci-platform.c: fix error return code

2012-08-15 Thread Alan Stern
On Tue, 14 Aug 2012, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Convert a possibly 0 error return code to a negative one, as returned elsewhere in the function. ... diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c index 91acdde..764e010

[PATCH 5/5] drivers/usb/host/ehci-platform.c: fix error return code

2012-08-14 Thread Julia Lawall
From: Julia Lawall Convert a possibly 0 error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e,e1,e2,e3,e4,x; @@ ( if (\(ret

[PATCH 5/5] drivers/usb/host/ehci-platform.c: fix error return code

2012-08-14 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Convert a possibly 0 error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression