Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices

2020-12-02 Thread Wolfram Sang
> With Doug's recent fixes in the DMA handling and the introduction of > proper iommu configuration, which Caleb tested [1], I think we're good > without this on the OnePlus. Caleb, please confirm. Yes, he confirmed already. I missed it was private only. Thanks for your heads up, too!

Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices

2020-12-02 Thread Bjorn Andersson
On Wed 02 Dec 09:39 CST 2020, Wolfram Sang wrote: > > > >> -if (!of_machine_is_compatible("lenovo,yoga-c630")) > > >> +if (!of_machine_is_compatible("lenovo,yoga-c630") && > > >> +!of_machine_is_compatible("oneplus,oneplus6")) > > > This hack seems to have been

Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices

2020-12-02 Thread Wolfram Sang
> >> - if (!of_machine_is_compatible("lenovo,yoga-c630")) > >> + if (!of_machine_is_compatible("lenovo,yoga-c630") && > >> + !of_machine_is_compatible("oneplus,oneplus6")) > > This hack seems to have been working around two separate issues. First > > with iommu active the GENI wrappers

Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices

2020-11-22 Thread Caleb Connolly
Hi Bjorn, It looks like I still have the same issue even with this patch applied. Regards, Caleb On 2020-11-22 03:47, Bjorn Andersson wrote: > On Thu 12 Nov 10:22 CST 2020, Caleb Connolly wrote: > >> The OnePlus 6/T has the same issue as the Yoga c630 causing a crash when DMA >> is used for

Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices

2020-11-21 Thread Bjorn Andersson
On Thu 12 Nov 10:22 CST 2020, Caleb Connolly wrote: > The OnePlus 6/T has the same issue as the Yoga c630 causing a crash when DMA > is used for i2c, so disable it. > > https://patchwork.kernel.org/patch/11133827/ > > Signed-off-by: Caleb Connolly > --- > drivers/i2c/busses/i2c-qcom-geni.c |

Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices

2020-11-17 Thread Akash Asthana
On 11/12/2020 9:52 PM, Caleb Connolly wrote: The OnePlus 6/T has the same issue as the Yoga c630 causing a crash when DMA is used for i2c, so disable it. https://patchwork.kernel.org/patch/11133827/ Signed-off-by: Caleb Connolly Reviewed-by : Akash Asthana -- The Qualcomm Innovation

[PATCH 5/5] i2c: geni: sdm845: dont perform DMA for OnePlus 6 devices

2020-11-12 Thread Caleb Connolly
The OnePlus 6/T has the same issue as the Yoga c630 causing a crash when DMA is used for i2c, so disable it. https://patchwork.kernel.org/patch/11133827/ Signed-off-by: Caleb Connolly --- drivers/i2c/busses/i2c-qcom-geni.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git