Re: [PATCH 5/5] i2c: i801: warn on i2c_handle_smbus_host_notify() errors

2016-08-01 Thread Jean Delvare
Hi Benjamin, On Thu, 28 Jul 2016 11:50:43 +0200, Benjamin Tissoires wrote: > i2c_handle_smbus_host_notify() returns 1 on success, something else on > errors. I did not notice before, but that doesn't make much sense IMHO. Your function follows the "negative number on error" return model, so retur

[PATCH 5/5] i2c: i801: warn on i2c_handle_smbus_host_notify() errors

2016-07-28 Thread Benjamin Tissoires
i2c_handle_smbus_host_notify() returns 1 on success, something else on errors. There is a chance we get called while Host Notify is not available (yet), so we need to clear the Host Notify bit in those rare case. Signed-off-by: Benjamin Tissoires --- drivers/i2c/busses/i2c-i801.c | 10 +-