Re: [PATCH 5/5] kasan, slub: fix conflicts with CONFIG_SLAB_FREELIST_HARDENED

2019-02-12 Thread Qian Cai
On 2/12/19 11:07 AM, Qian Cai wrote: > https://git.sr.ht/~cai/linux-debug/tree/master/dmesg > FYI, I just send a patch to take care of this. https://marc.info/?l=linux-mm=155002356527913=2

Re: [PATCH 5/5] kasan, slub: fix conflicts with CONFIG_SLAB_FREELIST_HARDENED

2019-02-12 Thread Qian Cai
On 2/12/19 9:42 AM, Andrey Konovalov wrote: > On Tue, Feb 12, 2019 at 2:43 PM Qian Cai wrote: >> >> >> >> On 2/12/19 8:26 AM, Andrey Konovalov wrote: >>> Hm, did you apply all 6 patches (the one that you sent and these five) >> Yes. > > I'm failing to reproduce this in QEMU. You're still

Re: [PATCH 5/5] kasan, slub: fix conflicts with CONFIG_SLAB_FREELIST_HARDENED

2019-02-12 Thread Andrey Konovalov
On Tue, Feb 12, 2019 at 2:43 PM Qian Cai wrote: > > > > On 2/12/19 8:26 AM, Andrey Konovalov wrote: > > Hm, did you apply all 6 patches (the one that you sent and these five) > Yes. I'm failing to reproduce this in QEMU. You're still using the same config, right? Could you share whole dmesg

Re: [PATCH 5/5] kasan, slub: fix conflicts with CONFIG_SLAB_FREELIST_HARDENED

2019-02-12 Thread Qian Cai
On 2/12/19 8:26 AM, Andrey Konovalov wrote: > Hm, did you apply all 6 patches (the one that you sent and these five) Yes.

Re: [PATCH 5/5] kasan, slub: fix conflicts with CONFIG_SLAB_FREELIST_HARDENED

2019-02-12 Thread Andrey Konovalov
On Tue, Feb 12, 2019 at 3:43 AM Qian Cai wrote: > > > > On 2/11/19 4:59 PM, Andrey Konovalov wrote: > > CONFIG_SLAB_FREELIST_HARDENED hashes freelist pointer with the address > > of the object where the pointer gets stored. With tag based KASAN we don't > > account for that when building

Re: [PATCH 5/5] kasan, slub: fix conflicts with CONFIG_SLAB_FREELIST_HARDENED

2019-02-11 Thread Qian Cai
On 2/11/19 4:59 PM, Andrey Konovalov wrote: > CONFIG_SLAB_FREELIST_HARDENED hashes freelist pointer with the address > of the object where the pointer gets stored. With tag based KASAN we don't > account for that when building freelist, as we call set_freepointer() with > the first argument

[PATCH 5/5] kasan, slub: fix conflicts with CONFIG_SLAB_FREELIST_HARDENED

2019-02-11 Thread Andrey Konovalov
CONFIG_SLAB_FREELIST_HARDENED hashes freelist pointer with the address of the object where the pointer gets stored. With tag based KASAN we don't account for that when building freelist, as we call set_freepointer() with the first argument untagged. This patch changes the code to properly