Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-28 Thread Petr Mladek
On Wed 2019-03-27 16:10:48, Sakari Ailus wrote: > Hi Petr, > > On Tue, Mar 26, 2019 at 04:13:07PM +0100, Petr Mladek wrote: > > On Fri 2019-03-22 17:29:30, Sakari Ailus wrote: > > > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to > > > support printing full path of the no

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-27 Thread Sakari Ailus
Hi Petr, On Tue, Mar 26, 2019 at 04:13:07PM +0100, Petr Mladek wrote: > On Fri 2019-03-22 17:29:30, Sakari Ailus wrote: > > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to > > support printing full path of the node, including its name ("f") and only > > the node's name ("

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Petr Mladek
On Tue 2019-03-26 16:30:21, Andy Shevchenko wrote: > On Tue, Mar 26, 2019 at 04:12:43PM +0200, Sakari Ailus wrote: > > On Tue, Mar 26, 2019 at 04:06:33PM +0200, Heikki Krogerus wrote: > > > On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > > > > > > > Do we support swnode here? >

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Petr Mladek
On Tue 2019-03-26 15:55:57, Andy Shevchenko wrote: > On Tue, Mar 26, 2019 at 03:39:47PM +0200, Sakari Ailus wrote: > > On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > > > On Sun, Mar 24, 2019 at 08:17:46PM +0200, Sakari Ailus wrote: > > > > The patch series by Petr I mentioned t

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Petr Mladek
On Fri 2019-03-22 17:29:30, Sakari Ailus wrote: > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to > support printing full path of the node, including its name ("f") and only > the node's name ("P") in the printk family of functions. The two flags > have equivalent function

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Heikki Krogerus
On Tue, Mar 26, 2019 at 04:12:43PM +0200, Sakari Ailus wrote: > Moi, > > On Tue, Mar 26, 2019 at 04:06:33PM +0200, Heikki Krogerus wrote: > > Hi, > > > > On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > > > > > > On ACPI based systems the resulting strings look like > > > > > >

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Andy Shevchenko
On Tue, Mar 26, 2019 at 04:12:43PM +0200, Sakari Ailus wrote: > On Tue, Mar 26, 2019 at 04:06:33PM +0200, Heikki Krogerus wrote: > > On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > > > > > Do we support swnode here? > > > > > > > > Good question. The swnodes have no hierarchy a

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Sakari Ailus
Moi, On Tue, Mar 26, 2019 at 04:06:33PM +0200, Heikki Krogerus wrote: > Hi, > > On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > > > > > On ACPI based systems the resulting strings look like > > > > > > > > > > \_SB.PCI0.CIO2.port@1.endpoint@0 > > > > > > > > > > where t

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Sakari Ailus
Hi Andy, On Tue, Mar 26, 2019 at 03:55:57PM +0200, Andy Shevchenko wrote: > On Tue, Mar 26, 2019 at 03:39:47PM +0200, Sakari Ailus wrote: > > On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > > > On Sun, Mar 24, 2019 at 08:17:46PM +0200, Sakari Ailus wrote: > > > > The patch seri

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Heikki Krogerus
Hi, On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > > > > On ACPI based systems the resulting strings look like > > > > > > > > \_SB.PCI0.CIO2.port@1.endpoint@0 > > > > > > > > where the nodes are separated by a dot (".") and the first three are > > > > ACPI device nod

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Andy Shevchenko
On Tue, Mar 26, 2019 at 03:39:47PM +0200, Sakari Ailus wrote: > On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > > On Sun, Mar 24, 2019 at 08:17:46PM +0200, Sakari Ailus wrote: > > The patch series by Petr I mentioned takes care about OF case. But it > > doesn't > > have covered

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Sakari Ailus
Hi Andy, On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > On Sun, Mar 24, 2019 at 08:17:46PM +0200, Sakari Ailus wrote: > > On Fri, Mar 22, 2019 at 07:21:14PM +0200, Andy Shevchenko wrote: > > > On Fri, Mar 22, 2019 at 05:29:30PM +0200, Sakari Ailus wrote: > > > > Add support for

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-26 Thread Andy Shevchenko
On Sun, Mar 24, 2019 at 08:17:46PM +0200, Sakari Ailus wrote: > On Fri, Mar 22, 2019 at 07:21:14PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 22, 2019 at 05:29:30PM +0200, Sakari Ailus wrote: > > > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to > > > support printing f

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-24 Thread Sakari Ailus
Hi Andy, Thanks for the comments. On Fri, Mar 22, 2019 at 07:21:14PM +0200, Andy Shevchenko wrote: > On Fri, Mar 22, 2019 at 05:29:30PM +0200, Sakari Ailus wrote: > > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to > > support printing full path of the node, including it

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-22 Thread Andy Shevchenko
On Fri, Mar 22, 2019 at 05:29:30PM +0200, Sakari Ailus wrote: > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to > support printing full path of the node, including its name ("f") and only > the node's name ("P") in the printk family of functions. The two flags > have equiv

[PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-22 Thread Sakari Ailus
Add support for %pfw conversion specifier (with "f" and "P" modifiers) to support printing full path of the node, including its name ("f") and only the node's name ("P") in the printk family of functions. The two flags have equivalent functionality to existing %pOF with the same two modifiers ("f"