Re: [PATCH 5/5] mm, compaction: more focused lru and pcplists draining

2014-11-19 Thread Vlastimil Babka
On 11/14/2014 08:05 AM, Joonsoo Kim wrote: >> What about this scenario, with pageblock order: >> >> - record cc->migrate_pfn pointing to pageblock X >> - isolate_migratepages() skips the pageblock due to e.g. skip bit, >> or the pageblock being a THP already... >> - loop to pageblock X+1, last_mig

Re: [PATCH 5/5] mm, compaction: more focused lru and pcplists draining

2014-11-13 Thread Joonsoo Kim
On Thu, Nov 13, 2014 at 01:47:08PM +0100, Vlastimil Babka wrote: > On 11/04/2014 01:37 AM, Joonsoo Kim wrote: > >On Mon, Nov 03, 2014 at 09:12:33AM +0100, Vlastimil Babka wrote: > >>On 10/27/2014 08:41 AM, Joonsoo Kim wrote: > >>>On Tue, Oct 07, 2014 at 05:33:39PM +0200, Vlastimil Babka wrote: > >>

Re: [PATCH 5/5] mm, compaction: more focused lru and pcplists draining

2014-11-13 Thread Vlastimil Babka
On 11/04/2014 01:37 AM, Joonsoo Kim wrote: On Mon, Nov 03, 2014 at 09:12:33AM +0100, Vlastimil Babka wrote: On 10/27/2014 08:41 AM, Joonsoo Kim wrote: On Tue, Oct 07, 2014 at 05:33:39PM +0200, Vlastimil Babka wrote: And, I wonder why last_migrated_pfn is set after isolate_migratepages(). Not

Re: [PATCH 5/5] mm, compaction: more focused lru and pcplists draining

2014-11-03 Thread Joonsoo Kim
On Mon, Nov 03, 2014 at 09:12:33AM +0100, Vlastimil Babka wrote: > On 10/27/2014 08:41 AM, Joonsoo Kim wrote: > >On Tue, Oct 07, 2014 at 05:33:39PM +0200, Vlastimil Babka wrote: > >>The goal of memory compaction is to create high-order freepages through page > >>migration. Page migration however pu

Re: [PATCH 5/5] mm, compaction: more focused lru and pcplists draining

2014-11-03 Thread Vlastimil Babka
On 10/27/2014 08:41 AM, Joonsoo Kim wrote: On Tue, Oct 07, 2014 at 05:33:39PM +0200, Vlastimil Babka wrote: The goal of memory compaction is to create high-order freepages through page migration. Page migration however puts pages on the per-cpu lru_add cache, which is later flushed to per-cpu pc

Re: [PATCH 5/5] mm, compaction: more focused lru and pcplists draining

2014-10-27 Thread Joonsoo Kim
On Tue, Oct 07, 2014 at 05:33:39PM +0200, Vlastimil Babka wrote: > The goal of memory compaction is to create high-order freepages through page > migration. Page migration however puts pages on the per-cpu lru_add cache, > which is later flushed to per-cpu pcplists, and only after pcplists are > dr

Re: [PATCH 5/5] mm, compaction: more focused lru and pcplists draining

2014-10-20 Thread Rik van Riel
On 10/07/2014 11:33 AM, Vlastimil Babka wrote: The goal of memory compaction is to create high-order freepages through page migration. Page migration however puts pages on the per-cpu lru_add cache, which is later flushed to per-cpu pcplists, and only after pcplists are drained the pages can actu

[PATCH 5/5] mm, compaction: more focused lru and pcplists draining

2014-10-07 Thread Vlastimil Babka
The goal of memory compaction is to create high-order freepages through page migration. Page migration however puts pages on the per-cpu lru_add cache, which is later flushed to per-cpu pcplists, and only after pcplists are drained the pages can actually merge. This can happen due to the per-cpu ca