Re: [PATCH 5/5] mm/hotplug: export try_online_node

2019-06-17 Thread 'Christoph Hellwig'
On Mon, Jun 17, 2019 at 06:00:00PM +1000, Alastair D'Silva wrote: > > And all that should go through our pmem APIs, not not directly poke into > mm > > internals. And if you still need core patches send them along with the > actual > > driver. > > I tried that, but I was getting crashes as the NU

RE: [PATCH 5/5] mm/hotplug: export try_online_node

2019-06-17 Thread Alastair D'Silva
KS ; Qian Cai ; Thomas Gleixner > ; Ingo Molnar ; Josh Poimboeuf > ; Jiri Kosina ; Mukesh Ojha > ; Mike Rapoport ; > Baoquan He ; Logan Gunthorpe > ; linux...@kvack.org; linux- > ker...@vger.kernel.org; linux-nvd...@lists.01.org > Subject: Re: [PATCH 5/5] mm/hotplug: export tr

Re: [PATCH 5/5] mm/hotplug: export try_online_node

2019-06-17 Thread Michal Hocko
[Cc Jerome - email thread starts http://lkml.kernel.org/r/20190617043635.13201-1-alast...@au1.ibm.com] On Mon 17-06-19 17:05:30, Alastair D'Silva wrote: > On Mon, 2019-06-17 at 08:59 +0200, Peter Zijlstra wrote: > > On Mon, Jun 17, 2019 at 02:36:31PM +1000, Alastair D'Silva wrote: > > > From: Al

Re: [PATCH 5/5] mm/hotplug: export try_online_node

2019-06-17 Thread Christoph Hellwig
On Mon, Jun 17, 2019 at 05:05:30PM +1000, Alastair D'Silva wrote: > On Mon, 2019-06-17 at 08:59 +0200, Peter Zijlstra wrote: > > On Mon, Jun 17, 2019 at 02:36:31PM +1000, Alastair D'Silva wrote: > > > From: Alastair D'Silva > > > > > > If an external driver module supplies physical memory and nee

Re: [PATCH 5/5] mm/hotplug: export try_online_node

2019-06-17 Thread Alastair D'Silva
On Mon, 2019-06-17 at 08:59 +0200, Peter Zijlstra wrote: > On Mon, Jun 17, 2019 at 02:36:31PM +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > If an external driver module supplies physical memory and needs to > > expose > > Why would you ever want to allow a module to do such a

Re: [PATCH 5/5] mm/hotplug: export try_online_node

2019-06-17 Thread Peter Zijlstra
On Mon, Jun 17, 2019 at 02:36:31PM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > If an external driver module supplies physical memory and needs to expose Why would you ever want to allow a module to do such a thing?

[PATCH 5/5] mm/hotplug: export try_online_node

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva If an external driver module supplies physical memory and needs to expose the memory on a specific NUMA node, it needs to be able to call try_online_node to allocate the data structures for the node. The previous assertion that all callers want to online the node, and that