Re: [PATCH 5/5] perf metric: Don't compute unused events.

2020-11-13 Thread Andi Kleen
The patch does a lot of stuff and is hard to review. The earlier patches all look good to me. > > static int > __expr__parse(double *val, struct expr_parse_ctx *ctx, const char *expr, > - int start, int runtime) > + bool compute_ids, int runtime) > { > struct expr_s

[PATCH 5/5] perf metric: Don't compute unused events.

2020-11-12 Thread Ian Rogers
For a metric like: EVENT1 if #smt_on else EVENT2 currently EVENT1 and EVENT2 will be measured and then when the metric is reported EVENT1 or EVENT2 will be printed depending on the value from smt_on() during the expr parsing. Computing both events is unnecessary and can lead to multiplexing as d