Re: [PATCH 5/5] perf tools: Fix NULL pointer deference when vdso not found

2016-06-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 23, 2016 at 09:07:04AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 23, 2016 at 10:02:39AM +0800, Wangnan (F) escreveu: > > Hi, > > > > This patch fixes a real crash problem when we do 'perf report' > > on an arm64 platform with arm32 program. > > It is introduced by commit

Re: [PATCH 5/5] perf tools: Fix NULL pointer deference when vdso not found

2016-06-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 23, 2016 at 10:02:39AM +0800, Wangnan (F) escreveu: > Hi, > > This patch fixes a real crash problem when we do 'perf report' > on an arm64 platform with arm32 program. > It is introduced by commit f9b2bdf228 ("perf tools: Find vdso > with the consider of cross-platform"). From dmesg re

Re: [PATCH 5/5] perf tools: Fix NULL pointer deference when vdso not found

2016-06-22 Thread Hekuang
在 2016/6/23 10:02, Wangnan (F) 写道: Hi, This patch fixes a real crash problem when we do 'perf report' on an arm64 platform with arm32 program. It is introduced by commit f9b2bdf228 ("perf tools: Find vdso with the consider of cross-platform"). From dmesg report, perf crashes in dso__type() bec

Re: [PATCH 5/5] perf tools: Fix NULL pointer deference when vdso not found

2016-06-22 Thread Wangnan (F)
Hi, This patch fixes a real crash problem when we do 'perf report' on an arm64 platform with arm32 program. It is introduced by commit f9b2bdf228 ("perf tools: Find vdso with the consider of cross-platform"). From dmesg report, perf crashes in dso__type() because dso is NULL. Still don't know wh

[PATCH 5/5] perf tools: Fix NULL pointer deference when vdso not found

2016-06-21 Thread He Kuang
We should check if 'dso' is a null pointer before passing it to the function dso__type(), otherwise a segfault will be raised in dso__data_get_fd(). In function machine__find_vdso(), the return value checking of 'dso' is missed and this patch fixes this issue. Signed-off-by: He Kuang --- tools/p