Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-20 Thread Javier Martinez Canillas
Hello Andreas, On 08/20/2014 12:21 PM, Javier Martinez Canillas wrote: > Hello Andreas, > > Thanks a lot for your feedback. > > On 08/19/2014 08:37 PM, Andreas Färber wrote: >>> &mmc_2 { >>> + vmmc-supply = <&tps65090_fet4>; >>> + vqmmc-supply = <&vqmmc_sdcard>; >>> status = "okay"; >>>

Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-20 Thread Javier Martinez Canillas
Hello Andreas, Thanks a lot for your feedback. On 08/19/2014 08:37 PM, Andreas Färber wrote: >> &mmc_2 { >> +vmmc-supply = <&tps65090_fet4>; >> +vqmmc-supply = <&vqmmc_sdcard>; >> status = "okay"; >> num-slots = <1>; >> supports-highspeed; > > A convention that I picked u

Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-20 Thread Javier Martinez Canillas
Hello Doug, On 08/19/2014 06:26 PM, Doug Anderson wrote: > > While your change is correct, I have a worry that it will break things > if it's merged before some patches that Yuvaraj is working on. > > Specifically the problem on pit and pi (and any exynos5250 / 5420 / > 5800 / ... boards using t

Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-19 Thread Andreas Färber
Hi Javier, Am 19.08.2014 17:08, schrieb Javier Martinez Canillas: > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts > b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 8e50042..5b9dbb9 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-

Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-19 Thread Doug Anderson
Javier, On Tue, Aug 19, 2014 at 8:08 AM, Javier Martinez Canillas wrote: > The VCC/VDD and VCCQ/VDD_IO power supplies for the MMC are > provided by the tps65090 fet4 and max77802 ldo4 regulators > respectively. Add the phandle to the regulators tree nodes > for the the dw_mmc device device. > > T

[PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-19 Thread Javier Martinez Canillas
The VCC/VDD and VCCQ/VDD_IO power supplies for the MMC are provided by the tps65090 fet4 and max77802 ldo4 regulators respectively. Add the phandle to the regulators tree nodes for the the dw_mmc device device. These DTS snippets were taken from the downstream ChromeOS 3.8 kernel Device Tree for P