Re: [PATCH 5/6] PCI: keystone: Add PCI legacy interrupt support for AM654

2021-04-02 Thread Marc Zyngier
On Thu, 25 Mar 2021 09:00:25 +, Kishon Vijay Abraham I wrote: > > Add PCI legacy interrupt support for AM654. AM654 has a single HW > interrupt line for all the four legacy interrupts INTA/INTB/INTC/INTD. > The HW interrupt line connected to GIC is a pulse interrupt whereas > the legacy

Re: [PATCH 5/6] PCI: keystone: Add PCI legacy interrupt support for AM654

2021-03-26 Thread Krzysztof Wilczyński
Hi Kishon, [...] > + if (!legacy_irq_domain) { > + dev_err(dev, "Failed to add irq domain for legacy irqs\n"); > + return -EINVAL; > + } [...] It would be "IRQ" and "IRQs" in the message above. [...] > - ret = ks_pcie_config_legacy_irq(ks_pcie); > - if

[PATCH 5/6] PCI: keystone: Add PCI legacy interrupt support for AM654

2021-03-25 Thread Kishon Vijay Abraham I
Add PCI legacy interrupt support for AM654. AM654 has a single HW interrupt line for all the four legacy interrupts INTA/INTB/INTC/INTD. The HW interrupt line connected to GIC is a pulse interrupt whereas the legacy interrupts by definition is level interrupt. In order to provide level interrupt