Re: [PATCH 5/6] UML - Network and pcap cleanup

2007-05-03 Thread Jeff Dike
On Thu, May 03, 2007 at 03:32:43PM +0200, Blaisorblade wrote: > This is due to patch: > "uml: drivers get release methods" > this could be useful to check whether other such changes are needed, by > grepping for platform_device_unregister in exit paths, also for ubd driver. > > That patch only fi

Re: [PATCH 5/6] UML - Network and pcap cleanup

2007-05-03 Thread Blaisorblade
On martedì 1 maggio 2007, Jeff Dike wrote: > [ Paolo - could you eyeball the globally valid MAC piece of this and > see if you think it's OK? ] Done, the patch can be accepted (I've not looked at the PCAP part). I've a note on the other fix there (the additional return). > Some network device cl

[PATCH 5/6] UML - Network and pcap cleanup

2007-05-01 Thread Jeff Dike
[ Paolo - could you eyeball the globally valid MAC piece of this and see if you think it's OK? ] Some network device cleanup. When setup_etheraddr found a globally valid MAC being assigned to an interface, it went ahead and used it rather than assigning a random MAC like the other cases do. This