Re: [PATCH 5/6] block: move three bvec helpers declaration into private helper

2021-01-04 Thread Christoph Hellwig
> +extern struct bio_vec *bvec_alloc(gfp_t, int, unsigned long *, mempool_t *); > +extern void bvec_free(mempool_t *, struct bio_vec *, unsigned int); > +extern unsigned int bvec_nr_vecs(unsigned short idx); Please drop the externs while you're at it. Otherwise looks good: Reviewed-by:

[PATCH 5/6] block: move three bvec helpers declaration into private helper

2020-12-29 Thread Ming Lei
bvec_alloc(), bvec_free() and bvec_nr_vecs() are only used inside block layer core functions, no need to declare them in public header. Signed-off-by: Ming Lei --- block/blk.h | 4 include/linux/bio.h | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git